[PR #2684] [MERGED] Fixed s3fs_flush to update pending meta for macos and nomultipart mode #2709

New issue

Closed

opened 2026-03-04 02:06:54 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:06:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2684
Author: @ggtakec
Created: 6/8/2025
Status: ✅ Merged
Merged: 6/8/2025
Merged by: @gaul

Base: master ← Head: fix/flush_release

📝 Commits (1)

c9f22f8 Fixed s3fs_flush to update pending meta for macos and nomultipart mode

📊 Changes

1 file changed (+13 additions, -1 deletions)

View changed files

📝 src/s3fs.cpp (+13 -1)

📄 Description

Relevant Issue (if applicable)

#2683

Details

In MacOS test, I found that test_update_time_cp_p often failed when the nomultipart option was specified.
(This issue has only been confirmed on MacOS so far.)
The reason for this is that when creating a new file, the pending Meta header information cannot be updated in time by s3fs_release processing.

Currently, s3fs_release uploads(flushes) the file contents and updates the pending Meta header information immediately afterwards, but there seems to be a case during this short period when file attributes are obtained.

The reason that s3fs_release performs Flush and Meta updates is because in the past there have been cases where s3fs_release was called without s3fs_flush being called. So that this processing needs to continue.
Also, since fuse does not wait for the result of s3fs_release operation before proceeding with the next operation, it appears that the attribute retrieval is called immediately after calling s3fs_release.

Therefore, I have keeped to process s3fs_release, and added the processing to update the Meta header information in s3fs_flush as same as it.

I hope that merging #2683 and this PR will reduce the number of test failures on MacOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2684 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 6/8/2025 **Status:** ✅ Merged **Merged:** 6/8/2025 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `fix/flush_release` --- ### 📝 Commits (1) - [`c9f22f8`](https://github.com/s3fs-fuse/s3fs-fuse/commit/c9f22f85ccca2dfef7ecb29646e1b05ee1ea71a4) Fixed s3fs_flush to update pending meta for macos and nomultipart mode ### 📊 Changes **1 file changed** (+13 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/s3fs.cpp` (+13 -1) </details> ### 📄 Description ### Relevant Issue (if applicable) #2683 ### Details In MacOS test, I found that `test_update_time_cp_p` often failed when the `nomultipart` option was specified. _(This issue has only been confirmed on MacOS so far.)_ The reason for this is that when creating a new file, the pending Meta header information cannot be updated in time by `s3fs_release` processing. Currently, `s3fs_release` uploads(flushes) the file contents and updates the pending Meta header information immediately afterwards, but there seems to be a case during this short period when file attributes are obtained. The reason that `s3fs_release` performs Flush and Meta updates is because in the past there have been cases where `s3fs_release` was called without `s3fs_flush` being called. So that this processing needs to continue. Also, since `fuse` does not wait for the result of `s3fs_release` operation before proceeding with the next operation, it appears that the attribute retrieval is called immediately after calling `s3fs_release`. Therefore, I have keeped to process `s3fs_release`, and added the processing to update the Meta header information in `s3fs_flush` as same as it. I hope that merging #2683 and this PR will reduce the number of test failures on MacOS. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>