[PR #2635] [MERGED] Fixed refactoring mistakes about loading IAM credentials #2683

New issue

Closed

opened 2026-03-04 02:06:46 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:06:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2635
Author: @ggtakec
Created: 1/18/2025
Status: ✅ Merged
Merged: 1/18/2025
Merged by: @gaul

Base: master ← Head: fix/iamrole_cred

📝 Commits (1)

0be0e5c Fixed refactoring mistakes about loading IAM credentials

📊 Changes

2 files changed (+6 additions, -3 deletions)

View changed files

📝 src/s3fs_cred.cpp (+5 -2)
📝 src/s3fs_cred.h (+1 -1)

📄 Description

Relevant Issue (if applicable)

#2602
#2612

Details

There was a mistake in the refactoring of #2602, so I fixed it.
The problem in issue #2612 is another reason in only v1.95, so it is different from this fix.
(The #2602 refactoring cleared the problem in v1.95, but it introduced this problem instead.)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2635 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 1/18/2025 **Status:** ✅ Merged **Merged:** 1/18/2025 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `fix/iamrole_cred` --- ### 📝 Commits (1) - [`0be0e5c`](https://github.com/s3fs-fuse/s3fs-fuse/commit/0be0e5c5dacdaf754c02ad467094721a83be02cd) Fixed refactoring mistakes about loading IAM credentials ### 📊 Changes **2 files changed** (+6 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/s3fs_cred.cpp` (+5 -2) 📝 `src/s3fs_cred.h` (+1 -1) </details> ### 📄 Description ### Relevant Issue (if applicable) #2602 #2612 ### Details There was a mistake in the refactoring of #2602, so I fixed it. The problem in issue #2612 is another reason in only v1.95, so it is different from this fix. (The #2602 refactoring cleared the problem in v1.95, but it introduced this problem instead.) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>