[PR #2721] [MERGED] Changed to use rename when serializing to FileCacheStat #2742

New issue

Closed

opened 2026-03-04 02:07:04 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:07:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2721
Author: @ggtakec
Created: 8/28/2025
Status: ✅ Merged
Merged: 8/29/2025
Merged by: @gaul

Base: master ← Head: fix/cache_file_stat

📝 Commits (1)

3da87c0 Changed to use rename when serializing to FileCacheStat

📊 Changes

5 files changed (+52 additions, -18 deletions)

View changed files

📝 src/fdcache_page.cpp (+5 -16)
📝 src/fdcache_page.h (+1 -1)
📝 src/fdcache_stat.cpp (+43 -0)
📝 src/fdcache_stat.h (+1 -0)
📝 src/test_page_list.cpp (+2 -1)

📄 Description

Relevant Issue (if applicable)

#2709

Details

Changed PageList::Serialize() to use flock to exclusively handle ftruncate->pwrite operations.
This fixes a bug reported in https://github.com/s3fs-fuse/s3fs-fuse/issues/2709#issuecomment-3226548346.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2721 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 8/28/2025 **Status:** ✅ Merged **Merged:** 8/29/2025 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `fix/cache_file_stat` --- ### 📝 Commits (1) - [`3da87c0`](https://github.com/s3fs-fuse/s3fs-fuse/commit/3da87c07dd9bf5cb5a714a2963ae766510a54305) Changed to use rename when serializing to FileCacheStat ### 📊 Changes **5 files changed** (+52 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `src/fdcache_page.cpp` (+5 -16) 📝 `src/fdcache_page.h` (+1 -1) 📝 `src/fdcache_stat.cpp` (+43 -0) 📝 `src/fdcache_stat.h` (+1 -0) 📝 `src/test_page_list.cpp` (+2 -1) </details> ### 📄 Description ### Relevant Issue (if applicable) #2709 ### Details Changed `PageList::Serialize()` to use `flock` to exclusively handle `ftruncate`->`pwrite` operations. This fixes a bug reported in https://github.com/s3fs-fuse/s3fs-fuse/issues/2709#issuecomment-3226548346. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>