[PR #2683] [MERGED] Fixed the random string generation in test script for macos #2707

New issue

Closed

opened 2026-03-04 02:06:54 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:06:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2683
Author: @ggtakec
Created: 6/7/2025
Status: ✅ Merged
Merged: 6/8/2025
Merged by: @gaul

Base: master ← Head: fix/macos_base64

📝 Commits (1)

a46fe8d Fixed the random string generation in test script for macos

📊 Changes

1 file changed (+1 additions, -8 deletions)

View changed files

📝 test/test-utils.sh (+1 -8)

📄 Description

Relevant Issue (if applicable)

n/a

Details

In the make_random_string function in the test script, the gbase64 command and the --break=0 option are used for macos, but an error occurs if not use --wrap=0 instead of this option.(It is unclear when this has been the case.)
So I modified it to use --wrap=0 for macos.
(Note: base64 can also be used in the macos runner of Github Actions, but this modification was not made.)

I also modified the script a little so that the reading from /dev/random and the passing of data to base64 (gbase64) do not result in unnecessary data.

Before changing the make_random_string function, the file name suffix was empty, which caused the test_update_metadata_external_small_object and test_update_metadata_external_large_object tests to fail.
(but this is not the only reason for the failure.)

I made this modification because the macos tests often failed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2683 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 6/7/2025 **Status:** ✅ Merged **Merged:** 6/8/2025 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `fix/macos_base64` --- ### 📝 Commits (1) - [`a46fe8d`](https://github.com/s3fs-fuse/s3fs-fuse/commit/a46fe8d57b78df4d9a1faabf448e20c15c570a57) Fixed the random string generation in test script for macos ### 📊 Changes **1 file changed** (+1 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `test/test-utils.sh` (+1 -8) </details> ### 📄 Description ### Relevant Issue (if applicable) n/a ### Details In the `make_random_string` function in the test script, the `gbase64` command and the `--break=0` option are used for macos, but an error occurs if not use `--wrap=0` instead of this option.(It is unclear when this has been the case.) So I modified it to use `--wrap=0` for macos. _(Note: `base64` can also be used in the macos runner of Github Actions, but this modification was not made.)_ I also modified the script a little so that the reading from `/dev/random` and the passing of data to `base64` (`gbase64`) do not result in unnecessary data. Before changing the `make_random_string` function, the file name suffix was empty, which caused the `test_update_metadata_external_small_object` and `test_update_metadata_external_large_object` tests to fail. _(but this is not the only reason for the failure.)_ I made this modification because the macos tests often failed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>