[PR #2736] [MERGED] Fixed negative stat cache data was not working #2755

New issue

Closed

opened 2026-03-04 02:07:08 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:07:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2736
Author: @ggtakec
Created: 10/4/2025
Status: ✅ Merged
Merged: 10/9/2025
Merged by: @gaul

Base: master ← Head: fix/negative_cache

📝 Commits (1)

9bddbde Fixed negative stat cache data was not working

📊 Changes

1 file changed (+16 additions, -23 deletions)

View changed files

📝 src/s3fs.cpp (+16 -23)

📄 Description

Relevant Issue (if applicable)

#2735

Details

This is a fix for issue #2735.

This was a bug introduced while modifying the PR #2707.
A negative cache check was overlooked.

This fix is consistent with the request count results examined in #2707 and has no impact on request count reduction, so there is no impact about request count.
(Compared to the code at github.com/s3fs-fuse/s3fs-fuse@0448ff460b)

Note that incorporating this bug into test code is difficult.
This is because the only way to determine whether a cache hit occurred and whether a subsequent request occurred is through logs.
Also, this would require multiple tests to check for non-existent objects, and would require detecting differences in their internal behavior.

Thanks to @francoisfreitag for his help.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2736 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 10/4/2025 **Status:** ✅ Merged **Merged:** 10/9/2025 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `fix/negative_cache` --- ### 📝 Commits (1) - [`9bddbde`](https://github.com/s3fs-fuse/s3fs-fuse/commit/9bddbde34a67c41ebdfbd3af688e0ca7ab5371a3) Fixed negative stat cache data was not working ### 📊 Changes **1 file changed** (+16 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `src/s3fs.cpp` (+16 -23) </details> ### 📄 Description ### Relevant Issue (if applicable) #2735 ### Details This is a fix for issue #2735. This was a bug introduced while modifying the PR #2707. A negative cache check was overlooked. This fix is consistent with the request count results examined in #2707 and has no impact on request count reduction, so there is no impact about request count. (Compared to the code at https://github.com/s3fs-fuse/s3fs-fuse/tree/0448ff460b1b7aac46ab7d348d8afa4b88dda822) Note that incorporating this bug into test code is difficult. This is because the only way to determine whether a cache hit occurred and whether a subsequent request occurred is through logs. Also, this would require multiple tests to check for non-existent objects, and would require detecting differences in their internal behavior. Thanks to @francoisfreitag for his help. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>