[PR #2155] [MERGED] Directly and simplify requests in mount point checks #2358

New issue

Closed

opened 2026-03-04 02:05:07 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:05:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2155
Author: @ggtakec
Created: 5/8/2023
Status: ✅ Merged
Merged: 5/13/2023
Merged by: @ggtakec

Base: master ← Head: fix_check_service

📝 Commits (1)

536f344 Directly and simplify requests in mount point checks

📊 Changes

1 file changed (+59 additions, -70 deletions)

View changed files

📝 src/s3fs.cpp (+59 -70)

📄 Description

Relevant Issue (if applicable)

#2153
(Related: #2151 #2063 #1728 #1687 #1460 )

Details

Simplified mount point checking

If user specifies a directory path for the mount point and user doesn't have access to the bucket top, the check is done in two steps(the bucket top and the directory).
(This is that @adamqqqplay pointed out by https://github.com/s3fs-fuse/s3fs-fuse/pull/2087#issuecomment-1537834762.)

Instead of this unnecessary two-step check, only the directory is checked when a directory path is specified.

I also reviewed and simplified the logic of the modified functions accordingly.

Fix output messages in checking mount point

Changed to output the recommended option when an error(warning) occurs in the mount point check.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2155 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 5/8/2023 **Status:** ✅ Merged **Merged:** 5/13/2023 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `fix_check_service` --- ### 📝 Commits (1) - [`536f344`](https://github.com/s3fs-fuse/s3fs-fuse/commit/536f3441499d09e971f74bbf954d90405f517ef1) Directly and simplify requests in mount point checks ### 📊 Changes **1 file changed** (+59 additions, -70 deletions) <details> <summary>View changed files</summary> 📝 `src/s3fs.cpp` (+59 -70) </details> ### 📄 Description ### Relevant Issue (if applicable) #2153 (Related: #2151 #2063 #1728 #1687 #1460 ) ### Details #### Simplified mount point checking If user specifies a directory path for the mount point and user doesn't have access to the bucket top, the check is done in two steps(the bucket top and the directory). (This is that @adamqqqplay pointed out by https://github.com/s3fs-fuse/s3fs-fuse/pull/2087#issuecomment-1537834762.) Instead of this unnecessary two-step check, only the directory is checked when a directory path is specified. I also reviewed and simplified the logic of the modified functions accordingly. #### Fix output messages in checking mount point Changed to output the recommended option when an error(warning) occurs in the mount point check. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>