[PR #1753] [MERGED] 1. fix RowFlush can not upload last part smaller than 5MB using NoCac… #2155

New issue

Closed

opened 2026-03-04 02:04:01 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:04:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1753
Author: @VVoidV
Created: 8/30/2021
Status: ✅ Merged
Merged: 8/30/2021
Merged by: @ggtakec

Base: master ← Head: fix_nocache

📝 Commits (1)

21aecf3 1. fix RowFlush can not upload last part smaller than 5MB using NoCacheMultipartPost;

📊 Changes

1 file changed (+3 additions, -4 deletions)

View changed files

📝 src/fdcache_entity.cpp (+3 -4)

📄 Description

fix RowFlush can not upload last part smaller than 5MB using NoCacheMultipartPost;
fix deadlock in UploadPendingMeta

Relevant Issue (if applicable)

https://github.com/s3fs-fuse/s3fs-fuse/issues/1746#issue-978094828

Details

see issue 1746 above. And x-amz-metadata-directive Header is missing in this case.
pseudo_obj->GetLastUntreated gets part lager than 5MB with default para, we should get all data in flush case.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1753 **Author:** [@VVoidV](https://github.com/VVoidV) **Created:** 8/30/2021 **Status:** ✅ Merged **Merged:** 8/30/2021 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `fix_nocache` --- ### 📝 Commits (1) - [`21aecf3`](https://github.com/s3fs-fuse/s3fs-fuse/commit/21aecf3ebbdcb568f51ca038bcfb324ac1093b85) 1. fix RowFlush can not upload last part smaller than 5MB using NoCacheMultipartPost; ### 📊 Changes **1 file changed** (+3 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/fdcache_entity.cpp` (+3 -4) </details> ### 📄 Description 1. fix RowFlush can not upload last part smaller than 5MB using NoCacheMultipartPost; 2. fix deadlock in UploadPendingMeta ### Relevant Issue (if applicable) https://github.com/s3fs-fuse/s3fs-fuse/issues/1746#issue-978094828 ### Details 1. see issue 1746 above. And *x-amz-metadata-directive* Header is missing in this case. 2. pseudo_obj->GetLastUntreated gets part lager than 5MB with default para, we should get all data in flush case. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>