[PR #905] [MERGED] Fix comparison in s3fs_strtoofft #1687

New issue

Closed

opened 2026-03-04 02:01:41 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:01:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/905
Author: @gaul
Created: 1/18/2019
Status: ✅ Merged
Merged: 1/20/2019
Merged by: @ggtakec

Base: master ← Head: clang-tidy/redundant

📝 Commits (1)

5a2dc03 Fix comparison in s3fs_strtoofft

📊 Changes

3 files changed (+15 additions, -1 deletions)

View changed files

📝 src/string_util.cpp (+1 -1)
📝 src/string_util.h (+1 -0)
📝 src/test_string_util.cpp (+13 -0)

📄 Description

Also backfill unit tests. Document limitations. Found via
clang-tidy.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/905 **Author:** [@gaul](https://github.com/gaul) **Created:** 1/18/2019 **Status:** ✅ Merged **Merged:** 1/20/2019 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `clang-tidy/redundant` --- ### 📝 Commits (1) - [`5a2dc03`](https://github.com/s3fs-fuse/s3fs-fuse/commit/5a2dc03a1c7131dc7f5e9b53e01a28f800d5bb07) Fix comparison in s3fs_strtoofft ### 📊 Changes **3 files changed** (+15 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/string_util.cpp` (+1 -1) 📝 `src/string_util.h` (+1 -0) 📝 `src/test_string_util.cpp` (+13 -0) </details> ### 📄 Description Also backfill unit tests. Document limitations. Found via clang-tidy. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>