[PR #1897] [MERGED] Fixed a bug about checking credential #2238

New issue

Closed

opened 2026-03-04 02:04:29 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:04:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1897
Author: @ggtakec
Created: 2/19/2022
Status: ✅ Merged
Merged: 2/19/2022
Merged by: @gaul

Base: master ← Head: fix_s3fscred

📝 Commits (1)

bc2ab52 Fixed a bug about checking credential

📊 Changes

1 file changed (+20 additions, -16 deletions)

View changed files

📝 src/s3fs_cred.cpp (+20 -16)

📄 Description

Relevant Issue (if applicable)

#1894

Details

This is a fix for the bug( in S3fsCred::CheckAllParams ) pointed out in #1894.
And there was a difference in the code( for analizing AWS_CREDENTIAL_FILE environment ) before migration, so it has been added and corrected.
The typo in the crappy end-of-line colon has also been fixed

This fix is related to #1878 #1891 #1896 .

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1897 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 2/19/2022 **Status:** ✅ Merged **Merged:** 2/19/2022 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `fix_s3fscred` --- ### 📝 Commits (1) - [`bc2ab52`](https://github.com/s3fs-fuse/s3fs-fuse/commit/bc2ab52cad14287cb850da66560fd3cd9366f26c) Fixed a bug about checking credential ### 📊 Changes **1 file changed** (+20 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `src/s3fs_cred.cpp` (+20 -16) </details> ### 📄 Description ### Relevant Issue (if applicable) #1894 ### Details This is a fix for the bug( in `S3fsCred::CheckAllParams` ) pointed out in #1894. And there was a difference in the code( for analizing `AWS_CREDENTIAL_FILE` environment ) before migration, so it has been added and corrected. _The typo in the crappy end-of-line colon has also been fixed_ This fix is related to #1878 #1891 #1896 . --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>