[PR #1277] [MERGED] Fixed insufficient upload size for mix multipart upload #1896

New issue

Closed

opened 2026-03-04 02:02:41 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:02:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1277
Author: @ggtakec
Created: 4/20/2020
Status: ✅ Merged
Merged: 4/22/2020
Merged by: @gaul

Base: master ← Head: fix_mix_mutiup

📝 Commits (1)

b2bad3a Fixed insufficient upload size for mix multipart upload

📊 Changes

2 files changed (+9 additions, -7 deletions)

View changed files

📝 src/fdcache.cpp (+8 -6)
📝 src/fdcache.h (+1 -1)

📄 Description

Relevant Issue (if applicable)

#1220 #1276

Details

This PR is a fix for the cause of #1220.

The bug of #1220 is that the size of one part does not meet the required size of multipart when uploading as mix multipart upload.
If the size of one part does not satisfy the required size of multipart, s3fs will download the data around that part and try to satisfy the required size.
And s3fs will upload with a part size that is larger than the requested size.
However, the code contained a bug, and although s3fs downloaded it, s3fs uploaded it without including that downloaded area.
This PR fixes this bug.

Although not included in this PR, the 416 HTTP response code will be corrected in the PR of #1276.
This PR and #1276 will be the correction of the defect of #1220.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1277 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 4/20/2020 **Status:** ✅ Merged **Merged:** 4/22/2020 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `fix_mix_mutiup` --- ### 📝 Commits (1) - [`b2bad3a`](https://github.com/s3fs-fuse/s3fs-fuse/commit/b2bad3ad357900b6df469f58f3abd564ead198c3) Fixed insufficient upload size for mix multipart upload ### 📊 Changes **2 files changed** (+9 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/fdcache.cpp` (+8 -6) 📝 `src/fdcache.h` (+1 -1) </details> ### 📄 Description ### Relevant Issue (if applicable) #1220 #1276 ### Details This PR is a fix for the cause of #1220. The bug of #1220 is that the size of one part does not meet the required size of multipart when uploading as mix multipart upload. If the size of one part does not satisfy the required size of multipart, s3fs will download the data around that part and try to satisfy the required size. And s3fs will upload with a part size that is larger than the requested size. However, the code contained a bug, and although s3fs downloaded it, s3fs uploaded it without including that downloaded area. This PR fixes this bug. Although not included in this PR, the 416 HTTP response code will be corrected in the PR of #1276. This PR and #1276 will be the correction of the defect of #1220. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>