[PR #1271] [MERGED] Fixed the truncation bug of stat file for cache file #1891

New issue

Closed

opened 2026-03-04 02:02:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:02:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1271
Author: @ggtakec
Created: 4/14/2020
Status: ✅ Merged
Merged: 4/19/2020
Merged by: @ggtakec

Base: master ← Head: fix_stat_file

📝 Commits (1)

811ea0c Fixed the truncation bug of stat file for cache file

📊 Changes

1 file changed (+36 additions, -5 deletions)

View changed files

📝 src/fdcache.cpp (+36 -5)

📄 Description

Relevant Issue (if applicable)

#1245 #1191

Details

Truncate cache page information file(stat)

When serializing the page information file(stat) of the cache file, the file was not truncated.

Wrap s3fs_strtoofft for PageList

s3fs_strtoofft function was throwing an exception, but PageList::Serialize method did not catch it.
Therefore, an intermediate wrap_strtoofft function was added that catches this exception and is called from PageList::Serialize to wrap the s3fs_strtoofft function.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1271 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 4/14/2020 **Status:** ✅ Merged **Merged:** 4/19/2020 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `fix_stat_file` --- ### 📝 Commits (1) - [`811ea0c`](https://github.com/s3fs-fuse/s3fs-fuse/commit/811ea0cb858e9adb5bbff5d3b1ffcbcf30a81547) Fixed the truncation bug of stat file for cache file ### 📊 Changes **1 file changed** (+36 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/fdcache.cpp` (+36 -5) </details> ### 📄 Description ### Relevant Issue (if applicable) #1245 #1191 ### Details #### Truncate cache page information file(stat) When serializing the page information file(stat) of the cache file, the file was not truncated. #### Wrap s3fs_strtoofft for PageList s3fs_strtoofft function was throwing an exception, but PageList::Serialize method did not catch it. Therefore, an intermediate wrap_strtoofft function was added that catches this exception and is called from PageList::Serialize to wrap the s3fs_strtoofft function. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>