mirror of
https://github.com/s3fs-fuse/s3fs-fuse.git
synced 2026-04-25 05:16:00 +03:00
[GH-ISSUE #2503] Compiling on Windows is broken #1220
Labels
No labels
bug
bug
dataloss
duplicate
enhancement
feature request
help wanted
invalid
need info
performance
pull-request
question
question
testing
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/s3fs-fuse#1220
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @MargaretaWhite23 on GitHub (Jul 24, 2024).
Original GitHub issue: https://github.com/s3fs-fuse/s3fs-fuse/issues/2503
Additional Information
Version of s3fs being used (
s3fs --version)Version of fuse being used (
pkg-config --modversion fuse,rpm -qi fuseordpkg -s fuse)Kernel information (
uname -r)3.5.3-d8b21b8c.x86_64GNU/Linux Distribution, if applicable (
cat /etc/os-release)How to run s3fs, if applicable
N/As3fs syslog messages (
grep s3fs /var/log/syslog,journalctl | grep s3fs, ors3fs outputs)N/ADetails about issue
Compilation of the Windows executable seems to be broken
(Following guide on:
https://github.com/s3fs-fuse/s3fs-fuse/blob/master/COMPILATION.md
)
Error message is as follows:
@gaul commented on GitHub (Jul 25, 2024):
Sorry no one active on this project uses Windows so we cannot help you. @siketyan added the original MSYS support so maybe they have a suggestion? The error appears to be in the WinFsp header itself:
so I suggest investigating why signal support is not working. I can submit a PR for some shallow issues but they won't address your main problem.
@siketyan commented on GitHub (Jul 26, 2024):
I am also not a Windows user for now but will try the compile instructions on this weekend.
@siketyan commented on GitHub (Jul 26, 2024):
I tried compiling s3fs-fuse on a fresh Windows + MSYS2 environment and here is what I learned:
libopenssl-develis no longer available, useopenssl-develinstead.-I/usr/includecompiler option is missing so we can't find any libc headers on compilation. Usemake CXXFLAGS=-I/usr/includeinstead ofmake.inc/fuse/winfsp_fuse.his missing import ofstring.hformemset(). Add#include <string.h>at the top of the file.fdcache_entity.cppusesfallocate()but it's not available. We can useposix_fallocate()but I don't know it's enough to work or not.After these considerations, I was able to finish the compile and
.\s3fs.exe --versionworks!@ggtakec commented on GitHub (Jul 27, 2024):
@siketyan Thanks!
Thanks. This issue can be resolved with a PR from @gaul, so I will merge it.
Thank you for noticing that
fallocateis not available.However,
posix_fallocatecannot be used to replacefallocate.To save space on the cache file, s3fs uses PUNCH HOLE(sparse file) instead of reserving the entire file size, thus
fallocateis used.@gaul commented on GitHub (Aug 6, 2024):
I believe that this is fixed -- please reopen if this is not addressed. It would be great if someone could further improve Windows support and set up a CI task to avoid future breakage.