[PR #2153] [MERGED] Allow mount points without directory objects by compat_dir #2357

New issue

Closed

opened 2026-03-04 02:05:07 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:05:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2153
Author: @ggtakec
Created: 5/4/2023
Status: ✅ Merged
Merged: 5/7/2023
Merged by: @ggtakec

Base: master ← Head: fix_mp

📝 Commits (1)

b096c6e Allow mount points without directory objects by compat_dir

📊 Changes

4 files changed (+65 additions, -37 deletions)

View changed files

📝 doc/man/s3fs.1.in (+2 -0)
📝 src/curl.cpp (+26 -4)
📝 src/curl.h (+1 -1)
📝 src/s3fs.cpp (+36 -32)

📄 Description

Relevant Issue (if applicable)

#2151
(Related: #2063 #1728 #1687 #1460 )

Details

Checking mount point still had issue #2151 after a series of fixes.
(It's almost identical to the issue mentioned in #1460.)

I would like to support the following cases:

User specifies a directory created by a client other than s3fs as the mount point.
(It means there is no object as this directory, and there is a file object etc under that path.)
And if user has no permission to the bucket and has permission to this mount point directory, s3fs does not start with an error.

This PR is code to support the above case.

There is already a compat_dir option to support directories created by clients other than s3fs and directories with no existing objects.
In the above case(no directory object for mount point), this PR code make s3fs start without an error by specifying the compat_dir option enabled.
This means consistent with the definition and intent of the compat_dir option.

@nchaly
I referred to your github.com/nchaly/s3fs-fuse@5670dd9dab code.
Thanks for your great help!

Testing of this PR code is difficult to automate, so I checked it manually.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2153 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 5/4/2023 **Status:** ✅ Merged **Merged:** 5/7/2023 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `fix_mp` --- ### 📝 Commits (1) - [`b096c6e`](https://github.com/s3fs-fuse/s3fs-fuse/commit/b096c6e68f91975304cfe603175c5879db989212) Allow mount points without directory objects by compat_dir ### 📊 Changes **4 files changed** (+65 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `doc/man/s3fs.1.in` (+2 -0) 📝 `src/curl.cpp` (+26 -4) 📝 `src/curl.h` (+1 -1) 📝 `src/s3fs.cpp` (+36 -32) </details> ### 📄 Description ### Relevant Issue (if applicable) #2151 (Related: #2063 #1728 #1687 #1460 ) ### Details Checking mount point still had issue #2151 after a series of fixes. (It's almost identical to the issue mentioned in #1460.) I would like to support the following cases: User specifies a directory created by a client other than s3fs as the mount point. (It means there is no object as this directory, and there is a file object etc under that path.) And if user has no permission to the bucket and has permission to this mount point directory, s3fs does not start with an error. This PR is code to support the above case. There is already a `compat_dir` option to support directories created by clients other than s3fs and directories with no existing objects. In the above case(no directory object for mount point), this PR code make s3fs start without an error by specifying the `compat_dir` option enabled. This means consistent with the definition and intent of the `compat_dir` option. @nchaly I referred to your https://github.com/nchaly/s3fs-fuse/commit/5670dd9dab9962e55ab1d3457ddf8025fecc7653 code. Thanks for your great help! Testing of this PR code is difficult to automate, so I checked it manually. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>