mirror of
https://github.com/s3fs-fuse/s3fs-fuse.git
synced 2026-04-25 13:26:00 +03:00
[PR #552] [MERGED] switch S3fsMultiCurl to use foreground threads #1542
Labels
No labels
bug
bug
dataloss
duplicate
enhancement
feature request
help wanted
invalid
need info
performance
pull-request
question
question
testing
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/s3fs-fuse#1542
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/552
Author: @orozery
Created: 4/2/2017
Status: ✅ Merged
Merged: 4/16/2017
Merged by: @ggtakec
Base:
master← Head:foreground_threads📝 Commits (1)
96764b7switch S3fsMultiCurl to use foreground threads📊 Changes
2 files changed (+84 additions, -154 deletions)
View changed files
📝
src/curl.cpp(+82 -153)📝
src/curl.h(+2 -1)📄 Description
Details
Currently, s3fs uses a multicurl handle to use parallel connections to s3.
The connections are indeed parallel, but are handled by a single CPU thread.
This creates a CPU bottleneck when reaching high throughput with TLS (HTTPS) connections.
To solve this issue, I propose a change to the S3fsMultiCurl class to use foreground pthreads instead of a multicurl handle.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.