[PR #1559] [MERGED] Do not periodically flush with nomultipartupload #2045

New issue

Closed

opened 2026-03-04 02:03:24 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:03:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1559
Author: @gaul
Created: 2/9/2021
Status: ✅ Merged
Merged: 2/11/2021
Merged by: @ggtakec

Base: master ← Head: nomultipart-dirty-data

📝 Commits (1)

6707036 Do not periodically flush with nomultipartupload

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 src/s3fs.cpp (+1 -0)

📄 Description

s3fs periodically flushes data to S3 and hole-punches the written
data, marking it as clean. Without multipart copy, s3fs would write
the now-zeroed data along with any new data. s3fs should not attempt
to periodically flush dirty data at all without multipart copy
support. Fixes #1542.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1559 **Author:** [@gaul](https://github.com/gaul) **Created:** 2/9/2021 **Status:** ✅ Merged **Merged:** 2/11/2021 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `nomultipart-dirty-data` --- ### 📝 Commits (1) - [`6707036`](https://github.com/s3fs-fuse/s3fs-fuse/commit/67070369cc092f3288525cfed38d10da1828487b) Do not periodically flush with nomultipartupload ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/s3fs.cpp` (+1 -0) </details> ### 📄 Description s3fs periodically flushes data to S3 and hole-punches the written data, marking it as clean. Without multipart copy, s3fs would write the now-zeroed data along with any new data. s3fs should not attempt to periodically flush dirty data at all without multipart copy support. Fixes #1542. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>