[PR #2367] [MERGED] Fixed a script of not functioning environment in Github Actions #2503

New issue

Closed

opened 2026-03-04 02:05:52 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:05:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/2367
Author: @ggtakec
Created: 11/15/2023
Status: ✅ Merged
Merged: 11/15/2023
Merged by: @gaul

Base: master ← Head: fix_configure

📝 Commits (1)

44b30db Fixed a script of not functioning environment in Github Actions

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 .github/workflows/linux-ci-helper.sh (+4 -4)

📄 Description

Relevant Issue (if applicable)

n/a

Details

I noticed a meaningless process in linux-ci-helper.sh and fixed it.
I believe this was done before the GHTHUB_ENV file was provided, but it is currently not working.

What isn't working are the option flags pass to configure and the CXXFLAG environment variable.
For fixing the option flag, it is written to GITHUB_ENV.
The CXXFLAG environment variable is currently set in Makefile.am. (especially -std=c++XX)
However, there is also a flag(S3FS_PTHREAD_ERRORCHECK=1) that is only used by Github Actions (CI), so I also write this to GITHUB_ENV.

I don't think it will affect the current build, but I have modified this file so that it fulfills the required functions.

@gaul
Please let me know if you have any problems.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/2367 **Author:** [@ggtakec](https://github.com/ggtakec) **Created:** 11/15/2023 **Status:** ✅ Merged **Merged:** 11/15/2023 **Merged by:** [@gaul](https://github.com/gaul) **Base:** `master` ← **Head:** `fix_configure` --- ### 📝 Commits (1) - [`44b30db`](https://github.com/s3fs-fuse/s3fs-fuse/commit/44b30db7deb5689183edac6af26641b766705b86) Fixed a script of not functioning environment in Github Actions ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/linux-ci-helper.sh` (+4 -4) </details> ### 📄 Description ### Relevant Issue (if applicable) n/a ### Details I noticed a meaningless process in `linux-ci-helper.sh` and fixed it. I believe this was done before the `GHTHUB_ENV` file was provided, but it is currently not working. What isn't working are the option flags pass to `configure` and the `CXXFLAG` environment variable. For fixing the option flag, it is written to `GITHUB_ENV`. The `CXXFLAG` environment variable is currently set in `Makefile.am`. (especially `-std=c++XX`) However, there is also a flag(`S3FS_PTHREAD_ERRORCHECK=1`) that is only used by Github Actions (CI), so I also write this to `GITHUB_ENV`. I don't think it will affect the current build, but I have modified this file so that it fulfills the required functions. @gaul Please let me know if you have any problems. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>