[PR #461] [MERGED] Revert the patch for Spotify API Bug after Spotify fixed the problem. #470

New issue

Closed

opened 2026-02-27 20:24:51 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/461
Author: @ramsayleung
Created: 3/8/2024
Status: ✅ Merged
Merged: 3/8/2024
Merged by: @ramsayleung

Base: master ← Head: ramsay/revert-float-point-patch

📝 Commits (4)

b339153 Revert the patch for Spotify API Bug after Spotify fixed the problem.
75ceb28 Migrate the deprecated API in chrono to the recommended ones.
cd55e43 Fix cargo clippy error.
55b263a Downgrade the version back to 0.12

📊 Changes

14 files changed (+65 additions, -136 deletions)

View changed files

📝 Cargo.toml (+1 -1)
📝 examples/ureq/seek_track.rs (+1 -1)
📝 examples/with_auto_reauth.rs (+2 -2)
📝 rspotify-model/src/artist.rs (+1 -3)
📝 rspotify-model/src/auth.rs (+3 -3)
📝 rspotify-model/src/context.rs (+5 -4)
📝 rspotify-model/src/custom_serde.rs (+23 -56)
➖ rspotify-model/src/data_type_patcher.rs (+0 -28)
📝 rspotify-model/src/image.rs (+0 -6)
📝 rspotify-model/src/lib.rs (+3 -6)
📝 src/clients/mod.rs (+1 -1)
📝 tests/test_models.rs (+11 -17)
📝 tests/test_oauth2.rs (+12 -6)
📝 tests/test_with_oauth.rs (+2 -2)

📄 Description

Description

Revert the patch for Spotify API Bug after Spotify fixed the problem.
Migrate the deprecated APIs in chrono to the recommended ones, otherwise the CI jobs will fail.

Motivation and Context

#452
#457

Dependencies

None

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How has this been tested?

All existing tests pass

Is this change properly documented?

It's not necessary.

Don't forget to add an entry to the CHANGELOG if necessary (new features, breaking changes, relevant internal improvements).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/461 **Author:** [@ramsayleung](https://github.com/ramsayleung) **Created:** 3/8/2024 **Status:** ✅ Merged **Merged:** 3/8/2024 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `ramsay/revert-float-point-patch` --- ### 📝 Commits (4) - [`b339153`](https://github.com/ramsayleung/rspotify/commit/b3391534baa91a018f6ffe63ad4daef09d10b40f) Revert the patch for Spotify API Bug after Spotify fixed the problem. - [`75ceb28`](https://github.com/ramsayleung/rspotify/commit/75ceb28c54aa9d29d4ce06cd91cc96f3b8ddcbde) Migrate the deprecated API in chrono to the recommended ones. - [`cd55e43`](https://github.com/ramsayleung/rspotify/commit/cd55e43f30fc25dd90aadec5cfa408eb6b833825) Fix cargo clippy error. - [`55b263a`](https://github.com/ramsayleung/rspotify/commit/55b263af473492286879c1eda994c1d7f3d8f2cd) Downgrade the version back to 0.12 ### 📊 Changes **14 files changed** (+65 additions, -136 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.toml` (+1 -1) 📝 `examples/ureq/seek_track.rs` (+1 -1) 📝 `examples/with_auto_reauth.rs` (+2 -2) 📝 `rspotify-model/src/artist.rs` (+1 -3) 📝 `rspotify-model/src/auth.rs` (+3 -3) 📝 `rspotify-model/src/context.rs` (+5 -4) 📝 `rspotify-model/src/custom_serde.rs` (+23 -56) ➖ `rspotify-model/src/data_type_patcher.rs` (+0 -28) 📝 `rspotify-model/src/image.rs` (+0 -6) 📝 `rspotify-model/src/lib.rs` (+3 -6) 📝 `src/clients/mod.rs` (+1 -1) 📝 `tests/test_models.rs` (+11 -17) 📝 `tests/test_oauth2.rs` (+12 -6) 📝 `tests/test_with_oauth.rs` (+2 -2) </details> ### 📄 Description ## Description 1. Revert the patch for Spotify API Bug after Spotify fixed the problem. 2. Migrate the deprecated APIs in chrono to the recommended ones, otherwise the CI jobs will fail. ## Motivation and Context #452 #457 ## Dependencies None ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ## How has this been tested? All existing tests pass ## Is this change properly documented? It's not necessary. Don't forget to add an entry to the CHANGELOG if necessary (new features, breaking changes, relevant internal improvements). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>