[PR #439] Getter and Setter of playlist api endpoint #457

Open
opened 2026-02-27 20:24:48 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/439
Author: @tomkimsour
Created: 8/30/2023
Status: 🔄 Open

Base: masterHead: add-image-cover


📝 Commits (5)

  • 1c9b09f add playlist cover getter and setter
  • f4425b6 move non oauth function to base.rs
  • b85d544 update changelog
  • 65e7c68 sample example for playlist
  • b6370ec wip : example implementation

📊 Changes

6 files changed (+322 additions, -1 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 Cargo.toml (+5 -0)
examples/playlist_with_oauth.rs (+253 -0)
📝 src/clients/base.rs (+16 -0)
📝 src/clients/oauth.rs (+29 -1)
📝 tests/test_with_oauth.rs (+18 -0)

📄 Description

Description

Please include a summary of the change and which issue is fixed
Getter and setter for playlist cover are missing as mentioned here #377 and #438

Motivation and Context

Please also include relevant motivation and context.

Dependencies

None

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How has this been tested?

I am yet trying to test both function under test_with_oauth.rs by creating a playlist, adding a cover, retrieving it and comparing both.
However I need guidance on how to test it as I am not able to figure out how to oauth for the tests. I am not sure what are the variable values required in the .env and even if I put a wrong value, it doesn't seem like the value is being read.

Is this change properly documented?

yes


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/439 **Author:** [@tomkimsour](https://github.com/tomkimsour) **Created:** 8/30/2023 **Status:** 🔄 Open **Base:** `master` ← **Head:** `add-image-cover` --- ### 📝 Commits (5) - [`1c9b09f`](https://github.com/ramsayleung/rspotify/commit/1c9b09fda2fb8b8430a22d6865a281608fb5be6e) add playlist cover getter and setter - [`f4425b6`](https://github.com/ramsayleung/rspotify/commit/f4425b67325d2520af20dfcb83cdf23a1c567481) move non oauth function to base.rs - [`b85d544`](https://github.com/ramsayleung/rspotify/commit/b85d544066f8974fc5bdec67f3822a043164ebe9) update changelog - [`65e7c68`](https://github.com/ramsayleung/rspotify/commit/65e7c685c63bf61101ae58f08d5ffc2885175e7d) sample example for playlist - [`b6370ec`](https://github.com/ramsayleung/rspotify/commit/b6370ec5f8f6cd64989f9dd963daff752e123ef4) wip : example implementation ### 📊 Changes **6 files changed** (+322 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `Cargo.toml` (+5 -0) ➕ `examples/playlist_with_oauth.rs` (+253 -0) 📝 `src/clients/base.rs` (+16 -0) 📝 `src/clients/oauth.rs` (+29 -1) 📝 `tests/test_with_oauth.rs` (+18 -0) </details> ### 📄 Description ## Description Please include a summary of the change and which issue is fixed Getter and setter for playlist cover are missing as mentioned here #377 and #438 ## Motivation and Context Please also include relevant motivation and context. ## Dependencies None ## Type of change Please delete options that are not relevant. - [x] New feature (non-breaking change which adds functionality) ## How has this been tested? I am yet trying to test both function under test_with_oauth.rs by creating a playlist, adding a cover, retrieving it and comparing both. However I need guidance on how to test it as I am not able to figure out how to oauth for the tests. I am not sure what are the variable values required in the .env and even if I put a wrong value, it doesn't seem like the value is being read. ## Is this change properly documented? yes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/rspotify#457
No description provided.