mirror of
https://github.com/ramsayleung/rspotify.git
synced 2026-04-25 23:45:52 +03:00
[PR #439] Getter and Setter of playlist api endpoint #457
Labels
No labels
Stale
bug
discussion
enhancement
good first issue
good first issue
help wanted
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/rspotify#457
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/ramsayleung/rspotify/pull/439
Author: @tomkimsour
Created: 8/30/2023
Status: 🔄 Open
Base:
master← Head:add-image-cover📝 Commits (5)
1c9b09fadd playlist cover getter and setterf4425b6move non oauth function to base.rsb85d544update changelog65e7c68sample example for playlistb6370ecwip : example implementation📊 Changes
6 files changed (+322 additions, -1 deletions)
View changed files
📝
CHANGELOG.md(+1 -0)📝
Cargo.toml(+5 -0)➕
examples/playlist_with_oauth.rs(+253 -0)📝
src/clients/base.rs(+16 -0)📝
src/clients/oauth.rs(+29 -1)📝
tests/test_with_oauth.rs(+18 -0)📄 Description
Description
Please include a summary of the change and which issue is fixed
Getter and setter for playlist cover are missing as mentioned here #377 and #438
Motivation and Context
Please also include relevant motivation and context.
Dependencies
None
Type of change
Please delete options that are not relevant.
How has this been tested?
I am yet trying to test both function under test_with_oauth.rs by creating a playlist, adding a cover, retrieving it and comparing both.
However I need guidance on how to test it as I am not able to figure out how to oauth for the tests. I am not sure what are the variable values required in the .env and even if I put a wrong value, it doesn't seem like the value is being read.
Is this change properly documented?
yes
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.