[PR #432] [MERGED] Add missing optional `market` field to some APIs #452

New issue

Closed

opened 2026-02-27 20:24:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/432
Author: @aome510
Created: 7/15/2023
Status: ✅ Merged
Merged: 7/15/2023
Merged by: @ramsayleung

Base: master ← Head: master

📝 Commits (6)

3b67dca add optional market parameter to album-related APIs and track API
fb7fdeb make market parameter in artist_top_tracks optional
4ebf67e Update CHANGELOG
e35116b fix clippy error
6a16ab9 update album usage in examples/ folder
bfdfe80 remove redundant mut

📊 Changes

7 files changed (+43 additions, -22 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 examples/client_creds.rs (+1 -1)
📝 examples/tasks.rs (+1 -1)
📝 examples/ureq/threading.rs (+1 -1)
📝 examples/with_auto_reauth.rs (+2 -2)
📝 src/clients/base.rs (+30 -10)
📝 tests/test_with_credential.rs (+7 -7)

📄 Description

Description

Resolves #423

added missing optional market field to following APIs:
- track
- album
- albums
- album_track
- album_track_manual
made market field in artist_top_tracks API optional instead of required

Context

Required for https://github.com/aome510/spotify-player/pull/207

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/432 **Author:** [@aome510](https://github.com/aome510) **Created:** 7/15/2023 **Status:** ✅ Merged **Merged:** 7/15/2023 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (6) - [`3b67dca`](https://github.com/ramsayleung/rspotify/commit/3b67dcaebf3c1d8a8c71e92163a02a1a2d902b8a) add optional `market` parameter to album-related APIs and `track` API - [`fb7fdeb`](https://github.com/ramsayleung/rspotify/commit/fb7fdebf703f4bfa3b39256b1b687feb05e7215f) make `market` parameter in `artist_top_tracks` optional - [`4ebf67e`](https://github.com/ramsayleung/rspotify/commit/4ebf67ea6c4f5f60766d6b8c9509f9269499089b) Update `CHANGELOG` - [`e35116b`](https://github.com/ramsayleung/rspotify/commit/e35116bcde18ad81b2975559e4db0e35f429ae54) fix clippy error - [`6a16ab9`](https://github.com/ramsayleung/rspotify/commit/6a16ab98c2ef20f283e0fd693f6ec9cc61e16b68) update `album` usage in `examples/` folder - [`bfdfe80`](https://github.com/ramsayleung/rspotify/commit/bfdfe80bdefa4e866bbd95324d016ec91514b9d7) remove redundant `mut` ### 📊 Changes **7 files changed** (+43 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `examples/client_creds.rs` (+1 -1) 📝 `examples/tasks.rs` (+1 -1) 📝 `examples/ureq/threading.rs` (+1 -1) 📝 `examples/with_auto_reauth.rs` (+2 -2) 📝 `src/clients/base.rs` (+30 -10) 📝 `tests/test_with_credential.rs` (+7 -7) </details> ### 📄 Description ## Description Resolves #423 - added missing optional `market` field to following APIs: - `track` - `album` - `albums` - `album_track` - `album_track_manual` - made `market` field in `artist_top_tracks` API optional instead of required ## Context Required for https://github.com/aome510/spotify-player/pull/207 ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>