[PR #352] [MERGED] Add debug_assert for mistake in playlist creation #407

Closed
opened 2026-02-27 20:24:36 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/352
Author: @marioortizmanero
Created: 7/27/2022
Status: Merged
Merged: 7/27/2022
Merged by: @marioortizmanero

Base: masterHead: create-playlist-assert


📝 Commits (1)

  • 604b6b9 Add debug_assert for mistake in playlist creation

📊 Changes

1 file changed (+6 additions, -0 deletions)

View changed files

📝 src/clients/oauth.rs (+6 -0)

📄 Description

Description

There's a simple invariant we don't check in playlist_create: we must have that !(collaborative && public).

Motivation and Context

See #349

Dependencies

None

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

CI passes

Is this change properly documented?

No need.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/352 **Author:** [@marioortizmanero](https://github.com/marioortizmanero) **Created:** 7/27/2022 **Status:** ✅ Merged **Merged:** 7/27/2022 **Merged by:** [@marioortizmanero](https://github.com/marioortizmanero) **Base:** `master` ← **Head:** `create-playlist-assert` --- ### 📝 Commits (1) - [`604b6b9`](https://github.com/ramsayleung/rspotify/commit/604b6b936b18103cbb63b978eb0eea818ea4d4fd) Add debug_assert for mistake in playlist creation ### 📊 Changes **1 file changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/clients/oauth.rs` (+6 -0) </details> ### 📄 Description ## Description There's a simple invariant we don't check in `playlist_create`: we must have that `!(collaborative && public)`. ## Motivation and Context See #349 ## Dependencies None ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) ## How has this been tested? CI passes ## Is this change properly documented? No need. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 20:24:36 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/rspotify#407
No description provided.