[PR #409] [MERGED] Change type of position parameter for playlist_add_item #440

Closed
opened 2026-02-27 20:24:45 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/409
Author: @ramsayleung
Created: 5/14/2023
Status: Merged
Merged: 5/22/2023
Merged by: @ramsayleung

Base: masterHead: ramsay_fix_playlist_add_item


📝 Commits (5)

  • 0f21709 Change type of position parameter.
  • 7d7edab Update CHANGELOG.md
  • 103dbef Update the comments.
  • 2789b51 Fix cargo fmt error.
  • 7bc84d1 Merge branch 'master' into ramsay_fix_playlist_add_item

📊 Changes

2 files changed (+8 additions, -4 deletions)

View changed files

📝 CHANGELOG.md (+5 -1)
📝 src/clients/oauth.rs (+3 -3)

📄 Description

Description

Change type of position parameter in playlist_add_items endpoint from Opinion<Duration> to Opinion<u32>

Motivation and Context

#407

Dependencies

None

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

  • check_playlist_tracks

Is this change properly documented?

Yes


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/409 **Author:** [@ramsayleung](https://github.com/ramsayleung) **Created:** 5/14/2023 **Status:** ✅ Merged **Merged:** 5/22/2023 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `ramsay_fix_playlist_add_item` --- ### 📝 Commits (5) - [`0f21709`](https://github.com/ramsayleung/rspotify/commit/0f21709b26f8fba8b924e1bd8b3c9258d846e8a0) Change type of position parameter. - [`7d7edab`](https://github.com/ramsayleung/rspotify/commit/7d7edabafe7c7a22e11eb58d95573b7b6986cadb) Update CHANGELOG.md - [`103dbef`](https://github.com/ramsayleung/rspotify/commit/103dbefc018adfe85b7d86ddb9758944077b805b) Update the comments. - [`2789b51`](https://github.com/ramsayleung/rspotify/commit/2789b511b9c848a1c913b661eeb5583e2be1b5d2) Fix cargo fmt error. - [`7bc84d1`](https://github.com/ramsayleung/rspotify/commit/7bc84d1e951bf7f7500d13d55bd543060488ef01) Merge branch 'master' into ramsay_fix_playlist_add_item ### 📊 Changes **2 files changed** (+8 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+5 -1) 📝 `src/clients/oauth.rs` (+3 -3) </details> ### 📄 Description ## Description Change type of `position` parameter in `playlist_add_items` endpoint from `Opinion<Duration>` to `Opinion<u32>` ## Motivation and Context #407 ## Dependencies None ## Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ## How has this been tested? - [x] `check_playlist_tracks` ## Is this change properly documented? Yes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 20:24:45 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/rspotify#440
No description provided.