[PR #257] [MERGED] Fix the remaining TODOs #349

New issue

Closed

opened 2026-02-27 20:24:22 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/257
Author: @marioortizmanero
Created: 9/25/2021
Status: ✅ Merged
Merged: 10/8/2021
Merged by: @ramsayleung

Base: master ← Head: todos

📝 Commits (10+)

1890dfa rename headers
02fe191 Added some basic logging
eafb9cb Hide internal request methods
02c3e8f Remove URI_WRONGTYPE2
7bc0d6d Fix playlist naming issues
10dfa4b Check state
91b1e7d Unnecessary boolean not operation
60b97ce Fix typo in changelog
321682d Fix ItemPositions as borrowed
52a3299 Merge branch 'master' into todos

📊 Changes

11 files changed (+181 additions, -136 deletions)

View changed files

📝 CHANGELOG.md (+11 -0)
📝 rspotify-model/src/idtypes.rs (+0 -5)
📝 rspotify-model/src/track.rs (+10 -4)
📝 src/auth_code.rs (+20 -15)
📝 src/auth_code_pkce.rs (+26 -18)
📝 src/client_creds.rs (+6 -3)
📝 src/clients/base.rs (+25 -17)
📝 src/clients/oauth.rs (+42 -43)
📝 src/lib.rs (+1 -2)
📝 tests/test_oauth2.rs (+20 -4)
📝 tests/test_with_oauth.rs (+20 -25)

📄 Description

Description

Renames headers to params
Remove URI_WRONGTYPE2
Adds some logging to the main library (#127)
Makes sure all the visibilities are correct (#127)
Fix playlist-related endpoints naming
Check state before request and after callback

Motivation and Context

We can finally close #127 after this, believe it or not! :))

Dependencies

None

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

CI passes successfully

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/257 **Author:** [@marioortizmanero](https://github.com/marioortizmanero) **Created:** 9/25/2021 **Status:** ✅ Merged **Merged:** 10/8/2021 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `todos` --- ### 📝 Commits (10+) - [`1890dfa`](https://github.com/ramsayleung/rspotify/commit/1890dfac06566c142b90c7d5cdafaf1434f2d1b4) rename `headers` - [`02fe191`](https://github.com/ramsayleung/rspotify/commit/02fe191b7be89a185f62ae90085cb3e7f914f51d) Added some basic logging - [`eafb9cb`](https://github.com/ramsayleung/rspotify/commit/eafb9cb60d154b3fa7c208440e63252ae5257571) Hide internal request methods - [`02c3e8f`](https://github.com/ramsayleung/rspotify/commit/02c3e8fa599973bed559eb43e5ba7fbc4a7e2bb7) Remove `URI_WRONGTYPE2` - [`7bc0d6d`](https://github.com/ramsayleung/rspotify/commit/7bc0d6d55cd5e9b917963f1420c7e05c60dbc3cd) Fix playlist naming issues - [`10dfa4b`](https://github.com/ramsayleung/rspotify/commit/10dfa4bc0c7ccf1ad4044b34a2c7bd5b836ba780) Check state - [`91b1e7d`](https://github.com/ramsayleung/rspotify/commit/91b1e7d761b0038f45844564db837b37d58a0102) Unnecessary boolean not operation - [`60b97ce`](https://github.com/ramsayleung/rspotify/commit/60b97ce6feb2f826179e6df1c0287dd4b8053894) Fix typo in changelog - [`321682d`](https://github.com/ramsayleung/rspotify/commit/321682ddfa912be3053da80a02bf01a90f68a1bf) Fix ItemPositions as borrowed - [`52a3299`](https://github.com/ramsayleung/rspotify/commit/52a32995dcb659fc3911e7b2365812db823cc278) Merge branch 'master' into todos ### 📊 Changes **11 files changed** (+181 additions, -136 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+11 -0) 📝 `rspotify-model/src/idtypes.rs` (+0 -5) 📝 `rspotify-model/src/track.rs` (+10 -4) 📝 `src/auth_code.rs` (+20 -15) 📝 `src/auth_code_pkce.rs` (+26 -18) 📝 `src/client_creds.rs` (+6 -3) 📝 `src/clients/base.rs` (+25 -17) 📝 `src/clients/oauth.rs` (+42 -43) 📝 `src/lib.rs` (+1 -2) 📝 `tests/test_oauth2.rs` (+20 -4) 📝 `tests/test_with_oauth.rs` (+20 -25) </details> ### 📄 Description ## Description * Renames `headers` to `params` * Remove `URI_WRONGTYPE2` * Adds some logging to the main library (#127) * Makes sure all the visibilities are correct (#127) * Fix playlist-related endpoints naming * Check state before request and after callback ## Motivation and Context We can ***finally*** close #127 after this, believe it or not! :)) ## Dependencies None ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [x] This change requires a documentation update ## How Has This Been Tested? CI passes successfully --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>