[PR #302] [MERGED] Label #386

Closed
opened 2026-02-27 20:24:31 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/302
Author: @Marekkon5
Created: 3/7/2022
Status: Merged
Merged: 3/7/2022
Merged by: @marioortizmanero

Base: masterHead: label


📝 Commits (4)

📊 Changes

2 files changed (+3 additions, -0 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 rspotify-model/src/album.rs (+2 -0)

📄 Description

Description

There is a label field missing in the FullAlbum struct. I know it's not in the documentation, but most albums do have label in the response from Spotify.

Example album ids:

40bmDCrlJYB1pEDNPcelol
5sIfNTG9Yp5bzYPcWxgEWo
0sNOF9WDwhWunNAHPD3Baj

Motivation and Context

Missing label field in Album response.

Dependencies

None

Type of change

Please delete options that are not relevant.

  • [ X ] Bug fix (non-breaking change which fixes an issue)

How has this been tested?

You can just run the client_creds (unmodified) and the example album will have label.

cargo run --example client_creds --features="env-file cli client-reqwest" 

Is this change properly documented?

Very minor change, let me know if I should add to CHANGELOG.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/302 **Author:** [@Marekkon5](https://github.com/Marekkon5) **Created:** 3/7/2022 **Status:** ✅ Merged **Merged:** 3/7/2022 **Merged by:** [@marioortizmanero](https://github.com/marioortizmanero) **Base:** `master` ← **Head:** `label` --- ### 📝 Commits (4) - [`01bad61`](https://github.com/ramsayleung/rspotify/commit/01bad61a2791b1cbb9aea4eee2744155d378fe0a) Label in album - [`6fbe1b2`](https://github.com/ramsayleung/rspotify/commit/6fbe1b2122ab33e0b43eba8063c9c357c6a0388f) FullAlbum label - [`4cd9c6a`](https://github.com/ramsayleung/rspotify/commit/4cd9c6af964e8490f9e377f6278bffb163d1b467) Album label doc - [`0bc1181`](https://github.com/ramsayleung/rspotify/commit/0bc11812f720421147813ff2cbc212c531828b04) Changelog, fmt ### 📊 Changes **2 files changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `rspotify-model/src/album.rs` (+2 -0) </details> ### 📄 Description ## Description There is a label field missing in the `FullAlbum` struct. I know it's not in the documentation, but most albums do have label in the response from Spotify. Example album ids: ``` 40bmDCrlJYB1pEDNPcelol 5sIfNTG9Yp5bzYPcWxgEWo 0sNOF9WDwhWunNAHPD3Baj ``` ## Motivation and Context Missing label field in Album response. ## Dependencies None ## Type of change Please delete options that are not relevant. - [ X ] Bug fix (non-breaking change which fixes an issue) ## How has this been tested? You can just run the `client_creds` (unmodified) and the example album will have label. ``` cargo run --example client_creds --features="env-file cli client-reqwest" ``` ## Is this change properly documented? Very minor change, let me know if I should add to CHANGELOG. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 20:24:31 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/rspotify#386
No description provided.