[PR #386] [MERGED] #385 Multiple `AlbumType` for `BaseClient::artist_albums_manual` #426

New issue

Closed

opened 2026-02-27 20:24:42 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/386
Author: @ekuinox
Created: 2/2/2023
Status: ✅ Merged
Merged: 2/19/2023
Merged by: @ramsayleung

Base: master ← Head: feature/multiple-album-types

📝 Commits (8)

425b5c2 artist_albums with multiple album_type
413ece5 Rename album_type parameter to include_groups
3fa06a9 Support IntoIter<Item=AlbumType>
db11a4f Added #386 to changelog.
ca66e6b Cover artist albums with zero album types
1ec264f Rename variable names
5e9cfbd Update doc for artist_albums
358cc9c fix cargo fmt error.

📊 Changes

3 files changed (+56 additions, -7 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 src/clients/base.rs (+17 -7)
📝 tests/test_with_credential.rs (+38 -0)

📄 Description

Description

fixes: #385

This change will allow BaseClient::artist_albums_manual to be given more than one AlbumType.
And It rename album_type of query parameter name to include_groups.

Motivation and Context

I want to get artist's albums by some AlbumType.

Dependencies

No changes.

Type of change

Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Please also list any relevant details for your test configuration

Test A: test_artists_albums
- My change doesnot break previous BaseClient::artist_albums_manual calls.
Test B: test_artists_albums_with_multiple_album_types
- AddBaseClient::artist_albums_manual call by AlbumType array.

Is this change properly documented?

Please make sure you've properly documented the changes you're making.

Don't forget to add an entry to the CHANGELOG if necessary (new features, breaking changes, relevant internal improvements).

Added to changelog.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/386 **Author:** [@ekuinox](https://github.com/ekuinox) **Created:** 2/2/2023 **Status:** ✅ Merged **Merged:** 2/19/2023 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `feature/multiple-album-types` --- ### 📝 Commits (8) - [`425b5c2`](https://github.com/ramsayleung/rspotify/commit/425b5c22fe4c5078d8a5a293120a2f4bfaf05fd1) artist_albums with multiple album_type - [`413ece5`](https://github.com/ramsayleung/rspotify/commit/413ece588b8baeed66bf06da2880fb2e0476c38b) Rename `album_type` parameter to `include_groups` - [`3fa06a9`](https://github.com/ramsayleung/rspotify/commit/3fa06a9fd6689920299ee9ab37a65563b1007c5b) Support `IntoIter<Item=AlbumType>` - [`db11a4f`](https://github.com/ramsayleung/rspotify/commit/db11a4f3b65814519649d84d7f060b7d36bba3d3) Added #386 to changelog. - [`ca66e6b`](https://github.com/ramsayleung/rspotify/commit/ca66e6b58338310d1896463328870605249d5320) Cover artist albums with zero album types - [`1ec264f`](https://github.com/ramsayleung/rspotify/commit/1ec264f34574bc629711484dcc949e6607f63971) Rename variable names - [`5e9cfbd`](https://github.com/ramsayleung/rspotify/commit/5e9cfbd7e91e62b0b920bc01605cfcf3c84a6c20) Update doc for `artist_albums` - [`358cc9c`](https://github.com/ramsayleung/rspotify/commit/358cc9cc75e6b4de1a0f654c2647f591c8641d35) fix cargo fmt error. ### 📊 Changes **3 files changed** (+56 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `src/clients/base.rs` (+17 -7) 📝 `tests/test_with_credential.rs` (+38 -0) </details> ### 📄 Description ## Description fixes: #385 This change will allow `BaseClient::artist_albums_manual` to be given more than one `AlbumType`. And It rename `album_type` of query parameter name to `include_groups`. ## Motivation and Context I want to get artist's albums by some `AlbumType`. ## Dependencies No changes. ## Type of change Please delete options that are not relevant. - [x] New feature (non-breaking change which adds functionality) ## How has this been tested? Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration - [x] Test A: test_artists_albums + My change doesnot break previous `BaseClient::artist_albums_manual` calls. - [x] Test B: test_artists_albums_with_multiple_album_types + Add`BaseClient::artist_albums_manual` call by `AlbumType` array. ## Is this change properly documented? Please make sure you've properly documented the changes you're making. Don't forget to add an entry to the CHANGELOG if necessary (new features, breaking changes, relevant internal improvements). - [x] Added to changelog. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>