[PR #193] [MERGED] Miscellaneous fixes #302

New issue

Closed

opened 2026-02-27 20:24:10 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/193
Author: @marioortizmanero
Created: 3/9/2021
Status: ✅ Merged
Merged: 3/10/2021
Merged by: @ramsayleung

Base: master ← Head: misc-fixes

📝 Commits (10+)

463d8b1 spacing fixes, simplify SeveralEpisodes
e3ed447 sort parts of changelog for faster lookup
256ffad update changelog
bead2e7 add test
9d38e13 cargo fmt
a311555 more spacing and fix docs
a666599 improve feature conflict errors
1e392bb cargo fmt
038b8a0 proper test locations
fc43ae9 fix scopes docs

📊 Changes

25 files changed (+219 additions, -126 deletions)

View changed files

📝 CHANGELOG.md (+54 -54)
📝 src/client.rs (+4 -2)
📝 src/lib.rs (+44 -49)
📝 src/macros.rs (+40 -12)
📝 src/model/album.rs (+1 -0)
📝 src/model/artist.rs (+2 -0)
📝 src/model/audio.rs (+3 -1)
📝 src/model/category.rs (+2 -0)
📝 src/model/context.rs (+2 -0)
📝 src/model/enums/mod.rs (+2 -1)
📝 src/model/idtypes.rs (+7 -4)
📝 src/model/image.rs (+1 -0)
📝 src/model/mod.rs (+12 -1)
📝 src/model/offset.rs (+2 -0)
📝 src/model/page.rs (+3 -0)
📝 src/model/playing.rs (+1 -0)
📝 src/model/playlist.rs (+1 -0)
📝 src/model/recommend.rs (+1 -0)
📝 src/model/search.rs (+2 -0)
📝 src/model/show.rs (+5 -1)

...and 5 more files

📄 Description

Description

This fixes a few things:

More spacing in the code
SeveralEpisodes -> Vec<FullEpisode>
Improve the conflicting HTTP clients compilation errors. You get one when none are enabled as well
Some fixes to the docs and made them simpler

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

New OAuth test:

Test test_get_several_episodes
Error for when both clients are enabled with cargo build --no-default-features --features=client-ureq,client-reqwest
Error for when no clients are enabled with cargo build --no-default-features

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/193 **Author:** [@marioortizmanero](https://github.com/marioortizmanero) **Created:** 3/9/2021 **Status:** ✅ Merged **Merged:** 3/10/2021 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `misc-fixes` --- ### 📝 Commits (10+) - [`463d8b1`](https://github.com/ramsayleung/rspotify/commit/463d8b142ec7074e79fe5ecac731d5c45a258cb8) spacing fixes, simplify SeveralEpisodes - [`e3ed447`](https://github.com/ramsayleung/rspotify/commit/e3ed4477521e7fd67b5d9fe8d23475fd448c30e6) sort parts of changelog for faster lookup - [`256ffad`](https://github.com/ramsayleung/rspotify/commit/256ffad0e25bac039382e8064b95d9840808f746) update changelog - [`bead2e7`](https://github.com/ramsayleung/rspotify/commit/bead2e76d50f999b96d11837b82a772f5fa789da) add test - [`9d38e13`](https://github.com/ramsayleung/rspotify/commit/9d38e13466faa1bf8d5e9bc8f852512c2dd229ed) cargo fmt - [`a311555`](https://github.com/ramsayleung/rspotify/commit/a311555f9d41f852e689e44c9a78167d25811f00) more spacing and fix docs - [`a666599`](https://github.com/ramsayleung/rspotify/commit/a666599ef4645891808477514817b59f1e2f118e) improve feature conflict errors - [`1e392bb`](https://github.com/ramsayleung/rspotify/commit/1e392bbde9ff92fd63867a92cb15f05fdd2c8871) cargo fmt - [`038b8a0`](https://github.com/ramsayleung/rspotify/commit/038b8a0aaa6ab88f51024aa9ba1825b630f4752f) proper test locations - [`fc43ae9`](https://github.com/ramsayleung/rspotify/commit/fc43ae99217a7d199664b27c2c787473398053e8) fix scopes docs ### 📊 Changes **25 files changed** (+219 additions, -126 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+54 -54) 📝 `src/client.rs` (+4 -2) 📝 `src/lib.rs` (+44 -49) 📝 `src/macros.rs` (+40 -12) 📝 `src/model/album.rs` (+1 -0) 📝 `src/model/artist.rs` (+2 -0) 📝 `src/model/audio.rs` (+3 -1) 📝 `src/model/category.rs` (+2 -0) 📝 `src/model/context.rs` (+2 -0) 📝 `src/model/enums/mod.rs` (+2 -1) 📝 `src/model/idtypes.rs` (+7 -4) 📝 `src/model/image.rs` (+1 -0) 📝 `src/model/mod.rs` (+12 -1) 📝 `src/model/offset.rs` (+2 -0) 📝 `src/model/page.rs` (+3 -0) 📝 `src/model/playing.rs` (+1 -0) 📝 `src/model/playlist.rs` (+1 -0) 📝 `src/model/recommend.rs` (+1 -0) 📝 `src/model/search.rs` (+2 -0) 📝 `src/model/show.rs` (+5 -1) _...and 5 more files_ </details> ### 📄 Description ## Description This fixes a few things: - More spacing in the code - `SeveralEpisodes` -> `Vec<FullEpisode>` - Improve the conflicting HTTP clients compilation errors. You get one when none are enabled as well - Some fixes to the docs and made them simpler ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ## How Has This Been Tested? New OAuth test: - [x] Test `test_get_several_episodes` - [x] Error for when both clients are enabled with `cargo build --no-default-features --features=client-ureq,client-reqwest` - [x] Error for when no clients are enabled with `cargo build --no-default-features` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>