[PR #265] [MERGED] Fix example for refresh token #358

Closed
opened 2026-02-27 20:24:24 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/265
Author: @marioortizmanero
Created: 10/11/2021
Status: Merged
Merged: 10/12/2021
Merged by: @ramsayleung

Base: ramsay_support_refresh_token_v2Head: fix-example


📝 Commits (7)

📊 Changes

6 files changed (+102 additions, -30 deletions)

View changed files

📝 examples/auth_code_pkce.rs (+2 -0)
📝 rspotify-model/src/idtypes.rs (+77 -20)
📝 src/clients/base.rs (+1 -1)
📝 src/clients/oauth.rs (+1 -1)
📝 tests/test_models.rs (+10 -5)
📝 tests/test_with_oauth.rs (+11 -3)

📄 Description

Description

It seems the PKCE example wasn't working after #262, since it forgot to set the previous token in order to refresh it. Same goes for the authenticated tests.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/265 **Author:** [@marioortizmanero](https://github.com/marioortizmanero) **Created:** 10/11/2021 **Status:** ✅ Merged **Merged:** 10/12/2021 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `ramsay_support_refresh_token_v2` ← **Head:** `fix-example` --- ### 📝 Commits (7) - [`b6c46cc`](https://github.com/ramsayleung/rspotify/commit/b6c46cca089bba4b0c5ec40aab56d8bb80e4a10e) Fix example - [`ad50727`](https://github.com/ramsayleung/rspotify/commit/ad50727a51323a8b2524efb759eb037641a253a9) Fix test as well - [`9afb69e`](https://github.com/ramsayleung/rspotify/commit/9afb69e3813ca7e890a526bb8b9c03656efa39e1) Fix silly volume debug_assert - [`48a962b`](https://github.com/ramsayleung/rspotify/commit/48a962b6d3c6cd25aac6ee0e1276884beba4113b) Fix UserId - [`0726d80`](https://github.com/ramsayleung/rspotify/commit/0726d808db69442882f45986526c87e5b0aeb74b) Merge branch 'fix-example' into fix-tests - [`8b0ea4a`](https://github.com/ramsayleung/rspotify/commit/8b0ea4a97286461eafb0937ed223ea413a9581a1) Fix test_playlist - [`e8dafb5`](https://github.com/ramsayleung/rspotify/commit/e8dafb5d315b4a3de7c9a8e66beebc526d9c0ee7) Merge pull request #266 from ramsayleung/fix-tests ### 📊 Changes **6 files changed** (+102 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `examples/auth_code_pkce.rs` (+2 -0) 📝 `rspotify-model/src/idtypes.rs` (+77 -20) 📝 `src/clients/base.rs` (+1 -1) 📝 `src/clients/oauth.rs` (+1 -1) 📝 `tests/test_models.rs` (+10 -5) 📝 `tests/test_with_oauth.rs` (+11 -3) </details> ### 📄 Description ## Description It seems the PKCE example wasn't working after #262, since it forgot to set the previous token in order to refresh it. Same goes for the authenticated tests. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 20:24:24 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/rspotify#358
No description provided.