mirror of
https://github.com/ramsayleung/rspotify.git
synced 2026-04-25 23:45:52 +03:00
[PR #133] [MERGED] Fix playlist related endpoints #262
Labels
No labels
Stale
bug
discussion
enhancement
good first issue
good first issue
help wanted
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/rspotify#262
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/ramsayleung/rspotify/pull/133
Author: @ghost
Created: 10/8/2020
Status: ✅ Merged
Merged: 10/24/2020
Merged by: @ramsayleung
Base:
master← Head:fix_playlist_api📝 Commits (10+)
292c082Fix get-playlists-tracks endpointfcbecb5Fix change-playlist-details endpoint3a9e6c5Fix unfollow-playlist endpoint55b16a0Fix add-tracks-to-playlist endpoint73b7d2fFix replace-playlists-tracks endpoint82d2006Fix reorder-playlists-tracks endpoint87abd82Fix remove-tracks-playlist endpoint3c5cb7bFix remove-tracks-playlist endpoint3201233Fix follow-playlist endpoint1419d25Fix check-user-following-playlist endpoint📊 Changes
2 files changed (+40 additions, -90 deletions)
View changed files
📝
src/client.rs(+20 -46)📝
tests/test_with_oauth.rs(+20 -44)📄 Description
Most of the API for handling playlists required a user ID in addition to the playlist ID. However, the Spotify API only requires the playlist ID for its endpoints, see here.
I suppose that in a previous version of the Spotify API, the owner ID was needed to correctly identify a playlist, but it seems to no longer be the case.
This PR fixes the calls to the playlist related actions, and renames the methods of the client for more clarity.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.