[PR #140] [CLOSED] WIP improvements from the meta-issue list #266

New issue

Closed

opened 2026-02-27 20:24:01 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/140
Author: @marioortizmanero
Created: 10/18/2020
Status: ❌ Closed

Base: master ← Head: improvements

📝 Commits (3)

febf330 Some iterator improvements
0af3100 Fallible generate_random_string makes more sense
6428a29 Last unwrap() I can remove/comment for now

📊 Changes

5 files changed (+54 additions, -59 deletions)

View changed files

📝 Cargo.toml (+1 -1)
📝 src/client.rs (+38 -51)
📝 src/lib.rs (+2 -1)
📝 src/oauth2.rs (+2 -1)
📝 src/util.rs (+11 -5)

📄 Description

Very WIP PR with some improvements from the meta-issue list. I'd like to finish #128 before this is merged because it blocks some of the changes I want to make. I'll be working on this later on.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/140 **Author:** [@marioortizmanero](https://github.com/marioortizmanero) **Created:** 10/18/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `improvements` --- ### 📝 Commits (3) - [`febf330`](https://github.com/ramsayleung/rspotify/commit/febf330390b6e1e49f81a804e17f20fa9daa3ebc) Some iterator improvements - [`0af3100`](https://github.com/ramsayleung/rspotify/commit/0af3100e6af49aaa2b6c6bdf823859cf5cd1bcd0) Fallible `generate_random_string` makes more sense - [`6428a29`](https://github.com/ramsayleung/rspotify/commit/6428a2951b09933d4578ca5f653241c976339a7e) Last `unwrap()` I can remove/comment for now ### 📊 Changes **5 files changed** (+54 additions, -59 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.toml` (+1 -1) 📝 `src/client.rs` (+38 -51) 📝 `src/lib.rs` (+2 -1) 📝 `src/oauth2.rs` (+2 -1) 📝 `src/util.rs` (+11 -5) </details> ### 📄 Description Very WIP PR with some improvements from the meta-issue list. I'd like to finish #128 before this is merged because it blocks some of the changes I want to make. I'll be working on this later on. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>