[PR #226] [MERGED] OAuth tests cleanup, they don't modify the user's profile anymore #325

New issue

Closed

opened 2026-02-27 20:24:16 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:24:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/226
Author: @marioortizmanero
Created: 7/14/2021
Status: ✅ Merged
Merged: 8/7/2021
Merged by: @ramsayleung

Base: master ← Head: oauth-tests

📝 Commits (10+)

2c1a038 First attempt at oauth tests fixing
2404190 Test for saved albums done
ed46d21 playback tests, some fixes
a250c8a fix #225
750d9fe test_repeat
25ab6c2 playlist tests
d49d23f clean up the rest of tests
e6ef925 clarify TODO
94ac8ce Revert changes to example
3f1f571 fixes #227

📊 Changes

9 files changed (+421 additions, -372 deletions)

View changed files

📝 .github/workflows/ci.yml (+2 -0)
📝 CHANGELOG.md (+1 -0)
📝 rspotify-model/src/enums/types.rs (+1 -1)
📝 rspotify-model/src/idtypes.rs (+3 -3)
📝 rspotify-model/src/playlist.rs (+1 -1)
📝 src/clients/base.rs (+4 -4)
📝 src/clients/oauth.rs (+43 -13)
📝 tests/test_models.rs (+1 -1)
📝 tests/test_with_oauth.rs (+365 -349)

📄 Description

Description

This PR takes care of the "Authenticated tests should actually not modify the user's account and cause minimal changes (as in, don't completely delete the user's library for a test)." task in #127.

It also includes some fixes so that they work:

Closes #225
Closes #227
Closes #228
Closes #229
Closes #231

Dependencies

None

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

cargo test --features=env-file,cli -- --ignored --test-threads=1
cargo test --features=env-file,cli,client-ureq,ureq-rustls-tls --no-default-features -- --ignored --test-threads=1

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/226 **Author:** [@marioortizmanero](https://github.com/marioortizmanero) **Created:** 7/14/2021 **Status:** ✅ Merged **Merged:** 8/7/2021 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `oauth-tests` --- ### 📝 Commits (10+) - [`2c1a038`](https://github.com/ramsayleung/rspotify/commit/2c1a03887512dc8f0a31e9842674dadeae25ce81) First attempt at oauth tests fixing - [`2404190`](https://github.com/ramsayleung/rspotify/commit/2404190ae1aeca636a7d9d4b12adeb911c68b679) Test for saved albums done - [`ed46d21`](https://github.com/ramsayleung/rspotify/commit/ed46d2142d76eefa7732f3ea543b260a5e5918a6) playback tests, some fixes - [`a250c8a`](https://github.com/ramsayleung/rspotify/commit/a250c8ad310b92d6f7921fb3e8a868e55dba6a8d) fix #225 - [`750d9fe`](https://github.com/ramsayleung/rspotify/commit/750d9fe7389a0a2b6232fb8f723751d70596e55b) test_repeat - [`25ab6c2`](https://github.com/ramsayleung/rspotify/commit/25ab6c215eb845e2ab1ae376a23bf83de7216bc7) playlist tests - [`d49d23f`](https://github.com/ramsayleung/rspotify/commit/d49d23fb98e08e8ce68336d547e251d89856ce66) clean up the rest of tests - [`e6ef925`](https://github.com/ramsayleung/rspotify/commit/e6ef9256318b979614ffaa0535dd8a5745e304d5) clarify TODO - [`94ac8ce`](https://github.com/ramsayleung/rspotify/commit/94ac8cee8d861646f319f3f954137b048a88a117) Revert changes to example - [`3f1f571`](https://github.com/ramsayleung/rspotify/commit/3f1f571ec4cc8dfcd0189be4ed475db98f55ecfa) fixes #227 ### 📊 Changes **9 files changed** (+421 additions, -372 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+2 -0) 📝 `CHANGELOG.md` (+1 -0) 📝 `rspotify-model/src/enums/types.rs` (+1 -1) 📝 `rspotify-model/src/idtypes.rs` (+3 -3) 📝 `rspotify-model/src/playlist.rs` (+1 -1) 📝 `src/clients/base.rs` (+4 -4) 📝 `src/clients/oauth.rs` (+43 -13) 📝 `tests/test_models.rs` (+1 -1) 📝 `tests/test_with_oauth.rs` (+365 -349) </details> ### 📄 Description ## Description This PR takes care of the "Authenticated tests should actually not modify the user's account and cause minimal changes (as in, don't completely delete the user's library for a test)." task in #127. It also includes some fixes so that they work: * Closes #225 * Closes #227 * Closes #228 * Closes #229 * Closes #231 ## Dependencies None ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ## How Has This Been Tested? ``` cargo test --features=env-file,cli -- --ignored --test-threads=1 cargo test --features=env-file,cli,client-ureq,ureq-rustls-tls --no-default-features -- --ignored --test-threads=1 ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>