[PR #77] [MERGED] Add missing "Show" and "Episode" types #229

Closed
opened 2026-02-27 20:23:52 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/77
Author: @simao
Created: 2/16/2020
Status: Merged
Merged: 2/18/2020
Merged by: @ramsayleung

Base: masterHead: add-missing-types


📝 Commits (1)

  • b1464ea Add missing "Show" and "Episode" types

📊 Changes

2 files changed (+8 additions, -2 deletions)

View changed files

📝 src/spotify/model/playlist.rs (+1 -1)
📝 src/spotify/senum.rs (+7 -1)

📄 Description

I ran into these types when using the spotify api, this would throw an error:

convert result failed, reason: Error("unknown variant `show`, expected one of `artist`, `album`, `track`, `playlist`, `user`", line: 57, column: 27); content

The same happened for episode.

The problem is for these types, "track" is null on FullPlaylist, so this changes the public api a bit...


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/77 **Author:** [@simao](https://github.com/simao) **Created:** 2/16/2020 **Status:** ✅ Merged **Merged:** 2/18/2020 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `add-missing-types` --- ### 📝 Commits (1) - [`b1464ea`](https://github.com/ramsayleung/rspotify/commit/b1464ea8ec256b8070187a721a5fe815570c5bf3) Add missing "Show" and "Episode" types ### 📊 Changes **2 files changed** (+8 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/spotify/model/playlist.rs` (+1 -1) 📝 `src/spotify/senum.rs` (+7 -1) </details> ### 📄 Description I ran into these types when using the spotify api, this would throw an error: ```convert result failed, reason: Error("unknown variant `show`, expected one of `artist`, `album`, `track`, `playlist`, `user`", line: 57, column: 27); content``` The same happened for `episode`. The problem is for these types, "track" is null on FullPlaylist, so this changes the public api a bit... --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 20:23:52 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/rspotify#229
No description provided.