[PR #75] [MERGED] Ramsay/fix clippy check error and bump rspotify version to 0.8 #226

Closed
opened 2026-02-27 20:23:51 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ramsayleung/rspotify/pull/75
Author: @ramsayleung
Created: 1/30/2020
Status: Merged
Merged: 1/30/2020
Merged by: @ramsayleung

Base: masterHead: ramsay/fix-clippy-check-error


📝 Commits (6)

  • 708c304 fix clippy check warning.
  • 67ae3f0 fix clippy check error, impl FromStr trait instead of impl function named from_str
  • ce0b3da allow needless_doctest_main lints
  • bfc3fbe remove continuoue-on-error configuration, stop step on error.
  • f636b80 update README.md, add github action badges.
  • 241f6b9 update rspotify to 0.8

📊 Changes

10 files changed (+457 additions, -634 deletions)

View changed files

📝 .github/workflows/ci.yml (+0 -4)
📝 CHANGELOG.md (+22 -0)
📝 Cargo.toml (+1 -1)
📝 README.md (+1 -0)
📝 src/lib.rs (+1 -0)
📝 src/spotify/client.rs (+1 -1)
📝 src/spotify/model/offset.rs (+4 -4)
📝 src/spotify/oauth2.rs (+31 -34)
📝 src/spotify/senum.rs (+390 -588)
📝 src/spotify/util.rs (+6 -2)

📄 Description

  1. optimize code by following clippy's guide
  2. bump rspotify version to 0.8

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ramsayleung/rspotify/pull/75 **Author:** [@ramsayleung](https://github.com/ramsayleung) **Created:** 1/30/2020 **Status:** ✅ Merged **Merged:** 1/30/2020 **Merged by:** [@ramsayleung](https://github.com/ramsayleung) **Base:** `master` ← **Head:** `ramsay/fix-clippy-check-error` --- ### 📝 Commits (6) - [`708c304`](https://github.com/ramsayleung/rspotify/commit/708c30483a57498521dd0854cf2dc4fc73bafe04) fix clippy check warning. - [`67ae3f0`](https://github.com/ramsayleung/rspotify/commit/67ae3f0e99233181a808467ac0c90a5003e98881) fix clippy check error, impl FromStr trait instead of impl function named from_str - [`ce0b3da`](https://github.com/ramsayleung/rspotify/commit/ce0b3da15e28076ecbb797c0250236dd132ad436) allow needless_doctest_main lints - [`bfc3fbe`](https://github.com/ramsayleung/rspotify/commit/bfc3fbe3e8ba7baa5ee481c47c235d1cc0fb8ae7) remove continuoue-on-error configuration, stop step on error. - [`f636b80`](https://github.com/ramsayleung/rspotify/commit/f636b804ffa7fbfb9e6684beea2fbfd24fc4ed60) update README.md, add github action badges. - [`241f6b9`](https://github.com/ramsayleung/rspotify/commit/241f6b982ab25f62be19f2452bb12b34673039ce) update rspotify to 0.8 ### 📊 Changes **10 files changed** (+457 additions, -634 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+0 -4) 📝 `CHANGELOG.md` (+22 -0) 📝 `Cargo.toml` (+1 -1) 📝 `README.md` (+1 -0) 📝 `src/lib.rs` (+1 -0) 📝 `src/spotify/client.rs` (+1 -1) 📝 `src/spotify/model/offset.rs` (+4 -4) 📝 `src/spotify/oauth2.rs` (+31 -34) 📝 `src/spotify/senum.rs` (+390 -588) 📝 `src/spotify/util.rs` (+6 -2) </details> ### 📄 Description 1. optimize code by following clippy's guide 2. bump rspotify version to 0.8 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 20:23:51 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/rspotify#226
No description provided.