[PR #540] [MERGED] Reimplement snapshot #540

New issue

Closed

opened 2026-02-28 00:42:34 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/540
Author: @Tinyblargon
Created: 2/1/2026
Status: ✅ Merged
Merged: 2/1/2026
Merged by: @Tinyblargon

Base: master ← Head: #527

📝 Commits (5)

2666fe5 refactor: Snapshots
5bb56f1 feat: add iterator
e99c72f feat: SelectSnapshot
c082a71 fix: Remove global Debug state
3bd4576 fix: typos

📊 Changes

52 files changed (+2823 additions, -395 deletions)

View changed files

📝 .gitignore (+3 -1)
📝 Makefile (+3 -1)
📝 cli/cobra.go (+1 -1)
📝 cli/command/list/list-snapshots.go (+72 -12)
📝 internal/mockServer/requests.go (+10 -0)
📝 main.go (+4 -4)
📝 proxmox/client.go (+4 -2)
📝 proxmox/client__api.go (+1 -2)
📝 proxmox/client__api__reusable.go (+92 -40)
📝 proxmox/client__new.go (+1 -0)
📝 proxmox/error.go (+9 -0)
📝 proxmox/helper_test.go (+1 -1)
📝 proxmox/session.go (+6 -7)
📝 proxmox/snapshot.go (+561 -95)
📝 proxmox/snapshot_test.go (+1579 -193)
📝 proxmox/staticcheck.go (+1 -1)
📝 test/api/ApiToken/create_token_test.go (+2 -2)
📝 test/api/ApiToken/delete_token_test.go (+1 -1)
📝 test/api/ApiToken/exists_token_test.go (+1 -1)
📝 test/api/ApiToken/list_token_test.go (+1 -1)

...and 32 more files

📄 Description

Fully re-implemented snapshot functionality.

Easy usable public functions.
Create snaphot tree as doubly linked tree.
Add interfaces for mocking.
Add unit tests for all functionality.
Add integration tests.

Releated to #527

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/540 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 2/1/2026 **Status:** ✅ Merged **Merged:** 2/1/2026 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `#527` --- ### 📝 Commits (5) - [`2666fe5`](https://github.com/Telmate/proxmox-api-go/commit/2666fe552e05b021b936e0d40565f9bda0cc4d1b) refactor: Snapshots - [`5bb56f1`](https://github.com/Telmate/proxmox-api-go/commit/5bb56f1f7522c4ab6e111d4091f0ef1a1fd87024) feat: add iterator - [`e99c72f`](https://github.com/Telmate/proxmox-api-go/commit/e99c72f3cb39e14495dee8b67aaff4170c811d95) feat: SelectSnapshot - [`c082a71`](https://github.com/Telmate/proxmox-api-go/commit/c082a7123b1b51f7d72abccbf45326641ff31641) fix: Remove global `Debug` state - [`3bd4576`](https://github.com/Telmate/proxmox-api-go/commit/3bd45769fbcd87d53506fa9c7456469597d0fd5f) fix: typos ### 📊 Changes **52 files changed** (+2823 additions, -395 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+3 -1) 📝 `Makefile` (+3 -1) 📝 `cli/cobra.go` (+1 -1) 📝 `cli/command/list/list-snapshots.go` (+72 -12) 📝 `internal/mockServer/requests.go` (+10 -0) 📝 `main.go` (+4 -4) 📝 `proxmox/client.go` (+4 -2) 📝 `proxmox/client__api.go` (+1 -2) 📝 `proxmox/client__api__reusable.go` (+92 -40) 📝 `proxmox/client__new.go` (+1 -0) 📝 `proxmox/error.go` (+9 -0) 📝 `proxmox/helper_test.go` (+1 -1) 📝 `proxmox/session.go` (+6 -7) 📝 `proxmox/snapshot.go` (+561 -95) 📝 `proxmox/snapshot_test.go` (+1579 -193) 📝 `proxmox/staticcheck.go` (+1 -1) 📝 `test/api/ApiToken/create_token_test.go` (+2 -2) 📝 `test/api/ApiToken/delete_token_test.go` (+1 -1) 📝 `test/api/ApiToken/exists_token_test.go` (+1 -1) 📝 `test/api/ApiToken/list_token_test.go` (+1 -1) _...and 32 more files_ </details> ### 📄 Description Fully re-implemented snapshot functionality. - Easy usable public functions. - Create snaphot tree as doubly linked tree. - Add interfaces for mocking. - Add unit tests for all functionality. - Add integration tests. Releated to #527 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>