[PR #524] [MERGED] feat: delete ha on guest deletion #527

New issue

Closed

opened 2026-02-28 00:42:32 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/524
Author: @Tinyblargon
Created: 11/24/2025
Status: ✅ Merged
Merged: 11/24/2025
Merged by: @Tinyblargon

Base: master ← Head: refactore-SelectID

📝 Commits (2)

8b7766f refactor: replace error with bool
379d30b feat: Delete HA when enabled

📊 Changes

3 files changed (+15 additions, -9 deletions)

View changed files

📝 proxmox/client__new.go (+3 -3)
📝 proxmox/config__guest__resource.go (+3 -3)
📝 proxmox/vmref.go (+9 -3)

📄 Description

Changed RawGuestResources.SelectID() to return a bool instead of a static error. This would make it easier for downstream projects to check if the ID exists.

Added deletion of the HA state to VmRef.Delete() simplifying logic downstream.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/524 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 11/24/2025 **Status:** ✅ Merged **Merged:** 11/24/2025 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `refactore-SelectID` --- ### 📝 Commits (2) - [`8b7766f`](https://github.com/Telmate/proxmox-api-go/commit/8b7766f1c87dc17ecda6a390eb559d3412900fca) refactor: replace error with bool - [`379d30b`](https://github.com/Telmate/proxmox-api-go/commit/379d30be1d8c149f7bb8886ce91eefde08996514) feat: Delete HA when enabled ### 📊 Changes **3 files changed** (+15 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/client__new.go` (+3 -3) 📝 `proxmox/config__guest__resource.go` (+3 -3) 📝 `proxmox/vmref.go` (+9 -3) </details> ### 📄 Description Changed `RawGuestResources.SelectID()` to return a bool instead of a static error. This would make it easier for downstream projects to check if the ID exists. Added deletion of the HA state to `VmRef.Delete()` simplifying logic downstream. Related to https://github.com/Telmate/terraform-provider-proxmox/issues/1449 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>