[PR #445] [MERGED] Fixes: . not allowed in guest name #475

Closed
opened 2026-02-28 00:42:19 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/445
Author: @Tinyblargon
Created: 8/4/2025
Status: Merged
Merged: 8/4/2025
Merged by: @Tinyblargon

Base: masterHead: #444


📝 Commits (3)

  • 3b5bac4 style: Fix Linter Warnigns
  • d4390db fix: error when GuestName contains .
  • ad6187d docs: GuestName type restrictions

📊 Changes

6 files changed (+98 additions, -64 deletions)

View changed files

📝 proxmox/config__guest.go (+22 -13)
📝 proxmox/config__guest_test.go (+14 -11)
📝 proxmox/config__lxc__new_test.go (+1 -1)
📝 proxmox/config__qemu_test.go (+1 -1)
📝 proxmox/vmref_test.go (+4 -4)
📝 test/data/test_data_guest/type_guestname.go (+56 -34)

📄 Description

Resolves #444


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/445 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 8/4/2025 **Status:** ✅ Merged **Merged:** 8/4/2025 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `#444` --- ### 📝 Commits (3) - [`3b5bac4`](https://github.com/Telmate/proxmox-api-go/commit/3b5bac441e2689aec7a5e5af0374d97b2bd108fc) style: Fix Linter Warnigns - [`d4390db`](https://github.com/Telmate/proxmox-api-go/commit/d4390dbb2d50f238583d4081c52198c7aa89f521) fix: error when GuestName contains `.` - [`ad6187d`](https://github.com/Telmate/proxmox-api-go/commit/ad6187d2a5aa0a0cda02dadafbe364cb71f00051) docs: GuestName type restrictions ### 📊 Changes **6 files changed** (+98 additions, -64 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config__guest.go` (+22 -13) 📝 `proxmox/config__guest_test.go` (+14 -11) 📝 `proxmox/config__lxc__new_test.go` (+1 -1) 📝 `proxmox/config__qemu_test.go` (+1 -1) 📝 `proxmox/vmref_test.go` (+4 -4) 📝 `test/data/test_data_guest/type_guestname.go` (+56 -34) </details> ### 📄 Description Resolves #444 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 00:42:19 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/proxmox-api-go#475
No description provided.