[PR #407] [MERGED] Simplify Qemu CRUD logic #445

New issue

Closed

opened 2026-02-28 00:42:13 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/407
Author: @Tinyblargon
Created: 3/24/2025
Status: ✅ Merged
Merged: 3/26/2025
Merged by: @Tinyblargon

Base: master ← Head: nil-panic-resize

📝 Commits (5)

6bb1eff fix: nil panic
599e889 refactor: exctract qemu create logic
59fe819 refactor: move ConfigQemu.setVmr()
27ff78b refactor: extract qemu update logic
d2c2de7 fix: pointer access without nil check

📊 Changes

1 file changed (+159 additions, -161 deletions)

View changed files

📝 proxmox/config_qemu.go (+159 -161)

📄 Description

Commit 6bb1eff013 fixes nil panic reported by @elsoa-invitech

Extract the update and create logic from ConfigQemu.setAdvanced() eliminating the function.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/407 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 3/24/2025 **Status:** ✅ Merged **Merged:** 3/26/2025 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `nil-panic-resize` --- ### 📝 Commits (5) - [`6bb1eff`](https://github.com/Telmate/proxmox-api-go/commit/6bb1eff013ea3a65e914735c75f5b7666603a934) fix: nil panic - [`599e889`](https://github.com/Telmate/proxmox-api-go/commit/599e889f293a7c9d633a154376ad25eda51f375c) refactor: exctract qemu create logic - [`59fe819`](https://github.com/Telmate/proxmox-api-go/commit/59fe81984c7543c07214ec21f53639055b200d07) refactor: move ConfigQemu.setVmr() - [`27ff78b`](https://github.com/Telmate/proxmox-api-go/commit/27ff78b6b60dd28eb37fd479e51f7673f07b51c2) refactor: extract qemu update logic - [`d2c2de7`](https://github.com/Telmate/proxmox-api-go/commit/d2c2de7c4dd9289401013b996e2f30b2b25de38e) fix: pointer access without nil check ### 📊 Changes **1 file changed** (+159 additions, -161 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config_qemu.go` (+159 -161) </details> ### 📄 Description Commit 6bb1eff013ea3a65e914735c75f5b7666603a934 fixes nil panic reported by @elsoa-invitech Extract the update and create logic from `ConfigQemu.setAdvanced()` eliminating the function. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>