[PR #406] [MERGED] Fix: Qemu guest migration #444

New issue

Closed

opened 2026-02-28 00:42:13 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/406
Author: @Tinyblargon
Created: 3/12/2025
Status: ✅ Merged
Merged: 3/12/2025
Merged by: @Tinyblargon

Base: master ← Head: #403

📝 Commits (2)

2cfc74e fix: guest won't be migrated
a560668 test: nil check tests

📊 Changes

5 files changed (+142 additions, -8 deletions)

View changed files

📝 proxmox/client.go (+19 -1)
📝 proxmox/client_test.go (+21 -0)
📝 proxmox/config_qemu.go (+4 -7)
📝 proxmox/vmref.go (+35 -0)
📝 proxmox/vmref_test.go (+63 -0)

📄 Description

Fixes the bug related to Qemu guest migration.

Deprecated: *Client.MigrateNode() to reduce code complexity.
Add: *VmRef.Migrate() this version has more validation.
Created: *Client.checkInitialized() to help with testing for nil,

Closes #403

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/406 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 3/12/2025 **Status:** ✅ Merged **Merged:** 3/12/2025 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `#403` --- ### 📝 Commits (2) - [`2cfc74e`](https://github.com/Telmate/proxmox-api-go/commit/2cfc74ede1e9f4d59c4ca03e05ccb86d50868035) fix: guest won't be migrated - [`a560668`](https://github.com/Telmate/proxmox-api-go/commit/a560668f1bf3316de4f90e6e51796f53da46d216) test: nil check tests ### 📊 Changes **5 files changed** (+142 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/client.go` (+19 -1) 📝 `proxmox/client_test.go` (+21 -0) 📝 `proxmox/config_qemu.go` (+4 -7) 📝 `proxmox/vmref.go` (+35 -0) 📝 `proxmox/vmref_test.go` (+63 -0) </details> ### 📄 Description Fixes the bug related to Qemu guest migration. Deprecated: `*Client.MigrateNode()` to reduce code complexity. Add: `*VmRef.Migrate()` this version has more validation. Created: `*Client.checkInitialized()` to help with testing for `nil`, Closes #403 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>