[PR #436] [MERGED] fix: no error returned when no version obtained from api #469

New issue

Closed

opened 2026-02-28 00:42:18 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/436
Author: @Tinyblargon
Created: 7/12/2025
Status: ✅ Merged
Merged: 7/12/2025
Merged by: @Tinyblargon

Base: master ← Head: version-error

📝 Commits (2)

633fa8f fix: no error returned when no version obtained from api
df34fd6 fix: variable wrong case

📊 Changes

2 files changed (+36 additions, -14 deletions)

View changed files

📝 proxmox/client.go (+17 -7)
📝 proxmox/client_test.go (+19 -7)

📄 Description

Return an error when we couldn't obtain the version from the API, instead of setting the version to 0.0.0 causing weird behaviors elsewhere.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/436 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 7/12/2025 **Status:** ✅ Merged **Merged:** 7/12/2025 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `version-error` --- ### 📝 Commits (2) - [`633fa8f`](https://github.com/Telmate/proxmox-api-go/commit/633fa8f64246bdc91230365b6e55f72b4ea222fb) fix: no error returned when no version obtained from api - [`df34fd6`](https://github.com/Telmate/proxmox-api-go/commit/df34fd65a4b3cb38631aa973b885bfb4c1a0dd97) fix: variable wrong case ### 📊 Changes **2 files changed** (+36 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/client.go` (+17 -7) 📝 `proxmox/client_test.go` (+19 -7) </details> ### 📄 Description Return an error when we couldn't obtain the version from the API, instead of setting the version to `0.0.0` causing weird behaviors elsewhere. Related to: https://github.com/Telmate/terraform-provider-proxmox/issues/1350 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>