[PR #393] [MERGED] redefine `nocheck` and `_unsafe` #436

New issue

Closed

opened 2026-02-28 00:42:11 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/393
Author: @Tinyblargon
Created: 1/5/2025
Status: ✅ Merged
Merged: 1/5/2025
Merged by: @Tinyblargon

Base: master ← Head: refactor-style

📝 Commits (1)

99c7869 redefine nocheck and _unsafe

📊 Changes

6 files changed (+116 additions, -120 deletions)

View changed files

📝 docs/style-guide/sdk.md (+38 -42)
📝 proxmox/config_guest.go (+7 -7)
📝 proxmox/config_pool.go (+44 -44)
📝 proxmox/config_pool_test.go (+18 -18)
📝 proxmox/config_qemu.go (+1 -1)
📝 proxmox/snapshot.go (+8 -8)

📄 Description

_unsafe was being used when we where ignoring type safety and API correctness. Now _unsafe only indicates ignored type safety and nocheck indicates ignored API correctness.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/393 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 1/5/2025 **Status:** ✅ Merged **Merged:** 1/5/2025 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `refactor-style` --- ### 📝 Commits (1) - [`99c7869`](https://github.com/Telmate/proxmox-api-go/commit/99c7869b66e7ca6b5a30241963bbc5397c03fcce) redefine `nocheck` and `_unsafe` ### 📊 Changes **6 files changed** (+116 additions, -120 deletions) <details> <summary>View changed files</summary> 📝 `docs/style-guide/sdk.md` (+38 -42) 📝 `proxmox/config_guest.go` (+7 -7) 📝 `proxmox/config_pool.go` (+44 -44) 📝 `proxmox/config_pool_test.go` (+18 -18) 📝 `proxmox/config_qemu.go` (+1 -1) 📝 `proxmox/snapshot.go` (+8 -8) </details> ### 📄 Description `_unsafe` was being used when we where ignoring type safety and API correctness. Now `_unsafe` only indicates ignored type safety and `nocheck` indicates ignored API correctness. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>