[PR #468] [MERGED] fix: test pool were failing, mainly due to typos #494

New issue

Closed

opened 2026-02-28 00:42:24 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/468
Author: @NemoDacremont
Created: 10/6/2025
Status: ✅ Merged
Merged: 10/6/2025
Merged by: @Tinyblargon

Base: master ← Head: fix/test-pool

📝 Commits (2)

2435024 fix(test): replace typo, tried to Create instead of Delete in Delete test
34fb471 fix(test): move Test_Pools_List in pool_create_destroy_test so it is executed before deleting the test pool

📊 Changes

2 files changed (+9 additions, -19 deletions)

View changed files

📝 test/api/Pool/pool_create_destroy_test.go (+9 -1)
➖ test/api/Pool/pool_list_test.go (+0 -18)

📄 Description

Fix typos making tests to fail, changes includes :

Change .Create to .Delete in delete test
Move pool list test in the create_destroy file, since it couldn't pass as it was executed after the Delete

fixes #469

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/468 **Author:** [@NemoDacremont](https://github.com/NemoDacremont) **Created:** 10/6/2025 **Status:** ✅ Merged **Merged:** 10/6/2025 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `fix/test-pool` --- ### 📝 Commits (2) - [`2435024`](https://github.com/Telmate/proxmox-api-go/commit/2435024c94c41f6163264bda7ce29c17d28d4a42) fix(test): replace typo, tried to Create instead of Delete in Delete test - [`34fb471`](https://github.com/Telmate/proxmox-api-go/commit/34fb4716575a9129ea7fe985e9cb2cd6b54d904c) fix(test): move Test_Pools_List in pool_create_destroy_test so it is executed before deleting the test pool ### 📊 Changes **2 files changed** (+9 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `test/api/Pool/pool_create_destroy_test.go` (+9 -1) ➖ `test/api/Pool/pool_list_test.go` (+0 -18) </details> ### 📄 Description Fix typos making tests to fail, changes includes : * Change `.Create` to `.Delete` in delete test * Move pool list test in the `create_destroy` file, since it couldn't pass as it was executed after the Delete fixes #469 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>