[PR #418] [MERGED] feat: explicit disk deletion #454

New issue

Closed

opened 2026-02-28 00:42:15 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/418
Author: @Tinyblargon
Created: 5/10/2025
Status: ✅ Merged
Merged: 5/10/2025
Merged by: @Tinyblargon

Base: master ← Head: #417

📝 Commits (1)

becd444 feat: explicit disk deletion

📊 Changes

6 files changed (+217 additions, -79 deletions)

View changed files

📝 proxmox/config_qemu_disk.go (+20 -38)
📝 proxmox/config_qemu_disk_ide.go (+5 -0)
📝 proxmox/config_qemu_disk_sata.go (+5 -0)
📝 proxmox/config_qemu_disk_scsi.go (+5 -0)
📝 proxmox/config_qemu_disk_virtio.go (+5 -0)
📝 proxmox/config_qemu_test.go (+177 -41)

📄 Description

Makes disk deletion explicit. A disk that is nil now means that we wont touch the disk during upgrade.
Added a lot of tests to ensure the old behavior has been replaced.

resolves #417

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/418 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 5/10/2025 **Status:** ✅ Merged **Merged:** 5/10/2025 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `#417` --- ### 📝 Commits (1) - [`becd444`](https://github.com/Telmate/proxmox-api-go/commit/becd444ced6097d14a9eb7ab2d3e9b9826db3db4) feat: explicit disk deletion ### 📊 Changes **6 files changed** (+217 additions, -79 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config_qemu_disk.go` (+20 -38) 📝 `proxmox/config_qemu_disk_ide.go` (+5 -0) 📝 `proxmox/config_qemu_disk_sata.go` (+5 -0) 📝 `proxmox/config_qemu_disk_scsi.go` (+5 -0) 📝 `proxmox/config_qemu_disk_virtio.go` (+5 -0) 📝 `proxmox/config_qemu_test.go` (+177 -41) </details> ### 📄 Description Makes disk deletion explicit. A disk that is `nil` now means that we wont touch the disk during upgrade. Added a lot of tests to ensure the old behavior has been replaced. resolves #417 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>