[PR #362] [MERGED] Rework: Qemu tests #418

New issue

Closed

opened 2026-02-28 00:42:07 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/362
Author: @Tinyblargon
Created: 9/1/2024
Status: ✅ Merged
Merged: 9/1/2024
Merged by: @Tinyblargon

Base: master ← Head: rework-qemu-tests

📝 Commits (3)

193b7df test: update procedure
de18a80 test: rewrite to be compatible with new structure
6ab91b9 style: change order

📊 Changes

1 file changed (+1497 additions, -1397 deletions)

View changed files

📝 proxmox/config_qemu_test.go (+1497 -1397)

📄 Description

Restructure the test to have less duplicate tests when we have an update and create test.
There now is an createUpdate test which will run the test once for create and once for update. reducing the amount of tests that have to be written.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/362 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 9/1/2024 **Status:** ✅ Merged **Merged:** 9/1/2024 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `rework-qemu-tests` --- ### 📝 Commits (3) - [`193b7df`](https://github.com/Telmate/proxmox-api-go/commit/193b7dff334296ce9a0d03920a1e6fb5f6840db8) test: update procedure - [`de18a80`](https://github.com/Telmate/proxmox-api-go/commit/de18a800bebd434de10f483b37d258e3e2c51166) test: rewrite to be compatible with new structure - [`6ab91b9`](https://github.com/Telmate/proxmox-api-go/commit/6ab91b900ac3ff9c98836e5f2788eec828eb8c32) style: change order ### 📊 Changes **1 file changed** (+1497 additions, -1397 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config_qemu_test.go` (+1497 -1397) </details> ### 📄 Description Restructure the test to have less duplicate tests when we have an `update` and `create` test. There now is an `createUpdate` test which will run the test once for create and once for update. reducing the amount of tests that have to be written. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>