[PR #359] [MERGED] feat: `ConfigQemu.Serials` Reimplement #417

New issue

Closed

opened 2026-02-28 00:42:07 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/359
Author: @Tinyblargon
Created: 8/20/2024
Status: ✅ Merged
Merged: 8/27/2024
Merged by: @Tinyblargon

Base: master ← Head: #350

📝 Commits (5)

9c0d498 feat: ConfigQemu.Serials Reimplement
3257066 refactor: remove unused variable
9479ef9 feat: SerialPath validate func
8135e8a fix: missing case /dev/
0430b85 fix: mutual exclusive error when Delete == true

📊 Changes

4 files changed (+421 additions, -96 deletions)

View changed files

📝 proxmox/config_qemu.go (+56 -95)
➕ proxmox/config_qemu_serial.go (+149 -0)
➕ proxmox/config_qemu_serial_test.go (+115 -0)
📝 proxmox/config_qemu_test.go (+101 -1)

📄 Description

Reimplemented serial adapters.
Test coverage 100%.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/359 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 8/20/2024 **Status:** ✅ Merged **Merged:** 8/27/2024 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `#350` --- ### 📝 Commits (5) - [`9c0d498`](https://github.com/Telmate/proxmox-api-go/commit/9c0d4986db900632e4323f7266adb17ae3be92d8) feat: `ConfigQemu.Serials` Reimplement - [`3257066`](https://github.com/Telmate/proxmox-api-go/commit/3257066f9fa42f22c6d7d073df954eeb2c9e05dc) refactor: remove unused variable - [`9479ef9`](https://github.com/Telmate/proxmox-api-go/commit/9479ef9263bb6a4a71fab3b2efdb617b8d1c64dd) feat: `SerialPath` validate func - [`8135e8a`](https://github.com/Telmate/proxmox-api-go/commit/8135e8ada99feadc34f46d79af86cdbcbc949988) fix: missing case `/dev/` - [`0430b85`](https://github.com/Telmate/proxmox-api-go/commit/0430b85d76cee74a83ab14d29b131ca9c3b124d2) fix: `mutual exclusive` error when `Delete == true` ### 📊 Changes **4 files changed** (+421 additions, -96 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config_qemu.go` (+56 -95) ➕ `proxmox/config_qemu_serial.go` (+149 -0) ➕ `proxmox/config_qemu_serial_test.go` (+115 -0) 📝 `proxmox/config_qemu_test.go` (+101 -1) </details> ### 📄 Description Reimplemented serial adapters. Test coverage 100%. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>