[PR #371] [MERGED] Rework: qemu usb #425

New issue

Closed

opened 2026-02-28 00:42:09 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:09 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/371
Author: @Tinyblargon
Created: 11/3/2024
Status: ✅ Merged
Merged: 11/3/2024
Merged by: @Tinyblargon

Base: master ← Head: rework-qemu-usb

📝 Commits (6)

ac9bbfa refactor: change if else with switch case
e2a435a feat: add QemuUSBs to API
84667cb feat: add QemuUSBs to SDK
faf73a4 feat: add QemuUSBs Validate
07ebfb7 chore: wildcard for go coverage files
d771101 chore: remove unused code

📊 Changes

9 files changed (+1203 additions, -58 deletions)

View changed files

📝 .gitignore (+2 -2)
📝 proxmox/config_qemu.go (+15 -51)
📝 proxmox/config_qemu_cloudinit.go (+5 -5)
📝 proxmox/config_qemu_test.go (+361 -0)
➕ proxmox/config_qemu_usb.go (+417 -0)
➕ proxmox/config_qemu_usb_test.go (+191 -0)
➕ proxmox/resource_mapping.go (+41 -0)
➕ proxmox/resource_mapping_test.go (+40 -0)
➕ test/data/test_data_resourcemapping/type_ResourceMappingUsbID.go (+131 -0)

📄 Description

Rework how USB devices work.

gets rid of the generic QemuDevices type and adds the QemuUSBs type.
adds logic for converting between the API and SDK.
added validation logic

100% code coverage.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/371 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 11/3/2024 **Status:** ✅ Merged **Merged:** 11/3/2024 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `rework-qemu-usb` --- ### 📝 Commits (6) - [`ac9bbfa`](https://github.com/Telmate/proxmox-api-go/commit/ac9bbfa10f163cf43d943b7d35843159ca046ad8) refactor: change `if else` with `switch` case - [`e2a435a`](https://github.com/Telmate/proxmox-api-go/commit/e2a435a030a105e58007cf202fe4acd9c8a8031a) feat: add `QemuUSBs` to API - [`84667cb`](https://github.com/Telmate/proxmox-api-go/commit/84667cbac14d4ef4eb689891fcd54fc99d1d8d35) feat: add `QemuUSBs` to SDK - [`faf73a4`](https://github.com/Telmate/proxmox-api-go/commit/faf73a4f2ebbdf3e1473b9a39df5d2b9e2259e60) feat: add `QemuUSBs` Validate - [`07ebfb7`](https://github.com/Telmate/proxmox-api-go/commit/07ebfb7494ceb215f5b07110c4c2dad69ccaa9a8) chore: wildcard for go coverage files - [`d771101`](https://github.com/Telmate/proxmox-api-go/commit/d7711012ce9363cd3dffea781cb172bf417fed02) chore: remove unused code ### 📊 Changes **9 files changed** (+1203 additions, -58 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+2 -2) 📝 `proxmox/config_qemu.go` (+15 -51) 📝 `proxmox/config_qemu_cloudinit.go` (+5 -5) 📝 `proxmox/config_qemu_test.go` (+361 -0) ➕ `proxmox/config_qemu_usb.go` (+417 -0) ➕ `proxmox/config_qemu_usb_test.go` (+191 -0) ➕ `proxmox/resource_mapping.go` (+41 -0) ➕ `proxmox/resource_mapping_test.go` (+40 -0) ➕ `test/data/test_data_resourcemapping/type_ResourceMappingUsbID.go` (+131 -0) </details> ### 📄 Description Rework how USB devices work. - gets rid of the generic `QemuDevices` type and adds the `QemuUSBs` type. - adds logic for converting between the API and SDK. - added validation logic 100% code coverage. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>