[PR #289] [MERGED] Implement stringer interface for UserID #371

Closed
opened 2026-02-28 00:41:56 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/289
Author: @Tinyblargon
Created: 12/18/2023
Status: Merged
Merged: 12/21/2023
Merged by: @mleone87

Base: masterHead: stringer


📝 Commits (2)

  • dae9584 feat: add String() fuction for UserID
  • f5bd53c deprecate UserID.ToString()

📊 Changes

6 files changed (+33 additions, -28 deletions)

View changed files

📝 main.go (+3 -3)
📝 proxmox/client.go (+1 -1)
📝 proxmox/config_group.go (+3 -3)
📝 proxmox/config_user.go (+19 -14)
📝 proxmox/config_user_test.go (+2 -2)
📝 test/cli/Users/user_sub_tests/user_sub_tests.go (+5 -5)

📄 Description


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/289 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 12/18/2023 **Status:** ✅ Merged **Merged:** 12/21/2023 **Merged by:** [@mleone87](https://github.com/mleone87) **Base:** `master` ← **Head:** `stringer` --- ### 📝 Commits (2) - [`dae9584`](https://github.com/Telmate/proxmox-api-go/commit/dae95843438375ab912d732dbd38acd5ec94c725) feat: add `String()` fuction for `UserID` - [`f5bd53c`](https://github.com/Telmate/proxmox-api-go/commit/f5bd53c1b61a3bb2d90984306abbe1608dcab4de) deprecate `UserID.ToString()` ### 📊 Changes **6 files changed** (+33 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `main.go` (+3 -3) 📝 `proxmox/client.go` (+1 -1) 📝 `proxmox/config_group.go` (+3 -3) 📝 `proxmox/config_user.go` (+19 -14) 📝 `proxmox/config_user_test.go` (+2 -2) 📝 `test/cli/Users/user_sub_tests/user_sub_tests.go` (+5 -5) </details> ### 📄 Description - Added `String()` to `UserID` implementing the stringer interface https://go.dev/tour/methods/17 - Marked the old `ToString()` as deprecated. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 00:41:56 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/proxmox-api-go#371
No description provided.