[PR #425] [MERGED] Lxc: features #460

Closed
opened 2026-02-28 00:42:16 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/425
Author: @Tinyblargon
Created: 6/14/2025
Status: Merged
Merged: 6/14/2025
Merged by: @Tinyblargon

Base: masterHead: lxc-features


📝 Commits (8)

  • d5ddb6e feat: default Privileged to false when nil
  • e60ab20 fix: panic
  • a1cdfa3 feat: split features in priviledged and unpriviledged
  • 988ac8f refactor: fix typos
  • 636c37b refactor: clerify returned priviledge
  • 83b7719 Update proxmox/config_lxc_new.go
  • 599e98b refactor: var lowercase
  • f8c67ff refactor: fix typo

📊 Changes

3 files changed (+464 additions, -172 deletions)

View changed files

📝 proxmox/config_lxc__features.go (+139 -45)
📝 proxmox/config_lxc_new.go (+30 -7)
📝 proxmox/config_lxc_new_test.go (+295 -120)

📄 Description

Make the privilege of an LXC guest default to false when none specified.
Fix panic when BootMount is nil.
Split LXC features in privileged and unprivileged section, better reflecting which options are available.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/425 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 6/14/2025 **Status:** ✅ Merged **Merged:** 6/14/2025 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `lxc-features` --- ### 📝 Commits (8) - [`d5ddb6e`](https://github.com/Telmate/proxmox-api-go/commit/d5ddb6e68e5dd52386496ac980414ad5cee27b89) feat: default `Privileged` to `false` when nil - [`e60ab20`](https://github.com/Telmate/proxmox-api-go/commit/e60ab205e3c4fac74ae82bd8fe92c83758144873) fix: panic - [`a1cdfa3`](https://github.com/Telmate/proxmox-api-go/commit/a1cdfa39cce97ecbfe8ff7958878dc1bf9507a42) feat: split features in priviledged and unpriviledged - [`988ac8f`](https://github.com/Telmate/proxmox-api-go/commit/988ac8f9df5f4a1ad1b8a9c07d894a96c7e52f79) refactor: fix typos - [`636c37b`](https://github.com/Telmate/proxmox-api-go/commit/636c37be7de1d8d03d73fcfd1ade91462e5cf3cb) refactor: clerify returned priviledge - [`83b7719`](https://github.com/Telmate/proxmox-api-go/commit/83b7719ee919b4f0d175e86543c931970dc08388) Update proxmox/config_lxc_new.go - [`599e98b`](https://github.com/Telmate/proxmox-api-go/commit/599e98bc4d30524061af3bebeaa8b229607c64ea) refactor: var lowercase - [`f8c67ff`](https://github.com/Telmate/proxmox-api-go/commit/f8c67ff347d62cf18735e8b1ea0cf75ae9418c7a) refactor: fix typo ### 📊 Changes **3 files changed** (+464 additions, -172 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config_lxc__features.go` (+139 -45) 📝 `proxmox/config_lxc_new.go` (+30 -7) 📝 `proxmox/config_lxc_new_test.go` (+295 -120) </details> ### 📄 Description Make the privilege of an LXC guest default to false when none specified. Fix panic when `BootMount` is `nil`. Split LXC features in privileged and unprivileged section, better reflecting which options are available. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 00:42:16 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/proxmox-api-go#460
No description provided.