[PR #274] [MERGED] Add type `SnapshotName` #362

New issue

Closed

opened 2026-02-28 00:41:54 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/274
Author: @Tinyblargon
Created: 7/17/2023
Status: ✅ Merged
Merged: 12/6/2023
Merged by: @mleone87

Base: master ← Head: Add-Type-SnapshotName

📝 Commits (5)

e2dc5b8 feat: add type SnapshotName
4b6250e feat: add SnapshotName.Validate()
dda7c40 feat: add ConfigSnapshot.Validate()
4ce3993 Add TODO
9426f5a fix: Parent should be of type SnapshotName

📊 Changes

7 files changed (+266 additions, -20 deletions)

View changed files

📝 cli/command/create/create-snapshot.go (+1 -1)
📝 cli/command/delete/delete-snapshot.go (+1 -1)
📝 cli/command/update/update-snapshotdescription.go (+1 -1)
📝 proxmox/client.go (+1 -1)
📝 proxmox/snapshot.go (+65 -16)
📝 proxmox/snapshot_test.go (+66 -0)
➕ test/data/test_data_snapshot/type_SnapshotName.go (+131 -0)

📄 Description

Work done this PR:

Added SnapshotName variable
Ensured all the type casting between SnapshotName and string is done correctly e2dc5b8c76 9426f5ac84
Added SnapshotName.Validate() 4b6250eabb
Added test for SnapshotName.Validate() 4b6250eabb
Added ConfigSnapshot.Validate() dda7c40dc5
Added test for ConfigSnapshot.Validate() dda7c40dc5

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/274 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 7/17/2023 **Status:** ✅ Merged **Merged:** 12/6/2023 **Merged by:** [@mleone87](https://github.com/mleone87) **Base:** `master` ← **Head:** `Add-Type-SnapshotName` --- ### 📝 Commits (5) - [`e2dc5b8`](https://github.com/Telmate/proxmox-api-go/commit/e2dc5b8c766a39431d4ef207116c8f2a9885fc54) feat: add type `SnapshotName` - [`4b6250e`](https://github.com/Telmate/proxmox-api-go/commit/4b6250eabb0f6984e16b16b225682e7fffae3b37) feat: add `SnapshotName.Validate()` - [`dda7c40`](https://github.com/Telmate/proxmox-api-go/commit/dda7c40dc5ff402f4dd50dfb55de03d6c6ac3bf2) feat: add `ConfigSnapshot.Validate()` - [`4ce3993`](https://github.com/Telmate/proxmox-api-go/commit/4ce3993d5cc03d374237c19276471e97c42f13b3) Add TODO - [`9426f5a`](https://github.com/Telmate/proxmox-api-go/commit/9426f5ac84211f98db554c5447a491494b1bcf2a) fix: `Parent` should be of type `SnapshotName` ### 📊 Changes **7 files changed** (+266 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `cli/command/create/create-snapshot.go` (+1 -1) 📝 `cli/command/delete/delete-snapshot.go` (+1 -1) 📝 `cli/command/update/update-snapshotdescription.go` (+1 -1) 📝 `proxmox/client.go` (+1 -1) 📝 `proxmox/snapshot.go` (+65 -16) 📝 `proxmox/snapshot_test.go` (+66 -0) ➕ `test/data/test_data_snapshot/type_SnapshotName.go` (+131 -0) </details> ### 📄 Description Work done this PR: - Added `SnapshotName` variable - Ensured all the type casting between `SnapshotName` and `string` is done correctly e2dc5b8c766a39431d4ef207116c8f2a9885fc54 9426f5ac84211f98db554c5447a491494b1bcf2a - Added `SnapshotName.Validate()` 4b6250eabb0f6984e16b16b225682e7fffae3b37 - Added test for `SnapshotName.Validate()` 4b6250eabb0f6984e16b16b225682e7fffae3b37 - Added `ConfigSnapshot.Validate()` dda7c40dc5ff402f4dd50dfb55de03d6c6ac3bf2 - Added test for `ConfigSnapshot.Validate()` dda7c40dc5ff402f4dd50dfb55de03d6c6ac3bf2 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>