mirror of
https://github.com/Telmate/proxmox-api-go.git
synced 2026-04-25 23:45:55 +03:00
[PR #271] [MERGED] Allow the creation of bind mounts for lxc containers #359
Labels
No labels
good first issue
issue/confirmed
issue/critical
proposal/accepted
pull-request
type/bug
type/enhancement
type/feature
type/question
type/refactoring
type/testing
type/testing
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/proxmox-api-go#359
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/Telmate/proxmox-api-go/pull/271
Author: @zinefer
Created: 7/8/2023
Status: ✅ Merged
Merged: 12/6/2023
Merged by: @mleone87
Base:
master← Head:bugfix-create-bind-mounts📝 Commits (1)
a8777abBugfix: Allow the creation of bind mounts for lxc containers📊 Changes
2 files changed (+5 additions, -1 deletions)
View changed files
📝
proxmox/config_lxc.go(+1 -0)📝
proxmox/config_qemu.go(+4 -1)📄 Description
This PR essentially makes size optional for a mount specified by volume.
I have tested this using
terraform-provider-proxmoxfor my use cases and it seems to work well. Is there somewhere I should look to add a test?Further reading:
Provider PR: https://github.com/Telmate/terraform-provider-proxmox/pull/806
Provider Issue: https://github.com/Telmate/terraform-provider-proxmox/issues/277
Bind mount docs: https://pve.proxmox.com/pve-docs/pve-admin-guide.html#_bind_mount_points
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
ConfigQemu.SerialsReimplement #417