[PR #271] [MERGED] Allow the creation of bind mounts for lxc containers #359

Closed
opened 2026-02-28 00:41:53 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/271
Author: @zinefer
Created: 7/8/2023
Status: Merged
Merged: 12/6/2023
Merged by: @mleone87

Base: masterHead: bugfix-create-bind-mounts


📝 Commits (1)

  • a8777ab Bugfix: Allow the creation of bind mounts for lxc containers

📊 Changes

2 files changed (+5 additions, -1 deletions)

View changed files

📝 proxmox/config_lxc.go (+1 -0)
📝 proxmox/config_qemu.go (+4 -1)

📄 Description

This PR essentially makes size optional for a mount specified by volume.

I have tested this using terraform-provider-proxmox for my use cases and it seems to work well. Is there somewhere I should look to add a test?

Further reading:

Provider PR: https://github.com/Telmate/terraform-provider-proxmox/pull/806
Provider Issue: https://github.com/Telmate/terraform-provider-proxmox/issues/277
Bind mount docs: https://pve.proxmox.com/pve-docs/pve-admin-guide.html#_bind_mount_points


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/271 **Author:** [@zinefer](https://github.com/zinefer) **Created:** 7/8/2023 **Status:** ✅ Merged **Merged:** 12/6/2023 **Merged by:** [@mleone87](https://github.com/mleone87) **Base:** `master` ← **Head:** `bugfix-create-bind-mounts` --- ### 📝 Commits (1) - [`a8777ab`](https://github.com/Telmate/proxmox-api-go/commit/a8777ab3342bc6b4ba18afc997829d80363b4033) Bugfix: Allow the creation of bind mounts for lxc containers ### 📊 Changes **2 files changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config_lxc.go` (+1 -0) 📝 `proxmox/config_qemu.go` (+4 -1) </details> ### 📄 Description This PR essentially makes size optional for a mount specified by volume. I have tested this using `terraform-provider-proxmox` for my use cases and it seems to work well. Is there somewhere I should look to add a test? ### Further reading: Provider PR: https://github.com/Telmate/terraform-provider-proxmox/pull/806 Provider Issue: https://github.com/Telmate/terraform-provider-proxmox/issues/277 Bind mount docs: https://pve.proxmox.com/pve-docs/pve-admin-guide.html#_bind_mount_points --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 00:41:53 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/proxmox-api-go#359
No description provided.