mirror of
https://github.com/Telmate/proxmox-api-go.git
synced 2026-04-25 15:35:51 +03:00
[PR #352] [MERGED] feat: implement ability to clone Qemu VM to different storage #413
Labels
No labels
good first issue
issue/confirmed
issue/critical
proposal/accepted
pull-request
type/bug
type/enhancement
type/feature
type/question
type/refactoring
type/testing
type/testing
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/proxmox-api-go#413
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/Telmate/proxmox-api-go/pull/352
Author: @OidaTiftla
Created: 8/11/2024
Status: ✅ Merged
Merged: 8/20/2024
Merged by: @Tinyblargon
Base:
master← Head:allow-clone-to-user-defined-storage📝 Commits (2)
0b6d93cfeat: implement ability to clone Qemu VM to different storage4a3279ddocs: integrate feedback from @Tinyblargon📊 Changes
2 files changed (+28 additions, -3 deletions)
View changed files
📝
proxmox/config_qemu.go(+7 -3)📝
test/api/Qemu/qemu_clone_test.go(+21 -0)📄 Description
Hi,
I want to create a clone to a different storage as it is possible through the Web UI and I noticed that this option is already documented in the README.md, but not yet implemented.
The changes in this PR will allow cloning a Qemu VM to a different storage location without changing the original configuration.
I also added a unit test, but I could not run and verify the unit test with
make test. I did not found out how to setup the unit test so the new storageother-storagewill exist when the unit test runs. Should I keep the new unit test, or should I remove it?Nevertheless I testet the change on my Proxmox 8 and it worked.
If there is anything I can improve in this PR, please let me know 😉.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.