[PR #352] [MERGED] feat: implement ability to clone Qemu VM to different storage #413

Closed
opened 2026-02-28 00:42:06 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/352
Author: @OidaTiftla
Created: 8/11/2024
Status: Merged
Merged: 8/20/2024
Merged by: @Tinyblargon

Base: masterHead: allow-clone-to-user-defined-storage


📝 Commits (2)

  • 0b6d93c feat: implement ability to clone Qemu VM to different storage
  • 4a3279d docs: integrate feedback from @Tinyblargon

📊 Changes

2 files changed (+28 additions, -3 deletions)

View changed files

📝 proxmox/config_qemu.go (+7 -3)
📝 test/api/Qemu/qemu_clone_test.go (+21 -0)

📄 Description

Hi,

I want to create a clone to a different storage as it is possible through the Web UI and I noticed that this option is already documented in the README.md, but not yet implemented.

The changes in this PR will allow cloning a Qemu VM to a different storage location without changing the original configuration.

I also added a unit test, but I could not run and verify the unit test with make test. I did not found out how to setup the unit test so the new storage other-storage will exist when the unit test runs. Should I keep the new unit test, or should I remove it?

Nevertheless I testet the change on my Proxmox 8 and it worked.

If there is anything I can improve in this PR, please let me know 😉.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/352 **Author:** [@OidaTiftla](https://github.com/OidaTiftla) **Created:** 8/11/2024 **Status:** ✅ Merged **Merged:** 8/20/2024 **Merged by:** [@Tinyblargon](https://github.com/Tinyblargon) **Base:** `master` ← **Head:** `allow-clone-to-user-defined-storage` --- ### 📝 Commits (2) - [`0b6d93c`](https://github.com/Telmate/proxmox-api-go/commit/0b6d93c438e9e723b11b9586ede6e6b0a4defb81) feat: implement ability to clone Qemu VM to different storage - [`4a3279d`](https://github.com/Telmate/proxmox-api-go/commit/4a3279d403de2563d19b710a78c9921feb02de9a) docs: integrate feedback from @Tinyblargon ### 📊 Changes **2 files changed** (+28 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config_qemu.go` (+7 -3) 📝 `test/api/Qemu/qemu_clone_test.go` (+21 -0) </details> ### 📄 Description Hi, I want to create a clone to a different storage as it is possible through the Web UI and I noticed that this option is already documented in the README.md, but not yet implemented. The changes in this PR will allow cloning a Qemu VM to a different storage location without changing the original configuration. I also added a unit test, but I could not run and verify the unit test with `make test`. I did not found out how to setup the unit test so the new storage `other-storage` will exist when the unit test runs. Should I keep the new unit test, or should I remove it? Nevertheless I testet the change on my Proxmox 8 and it worked. If there is anything I can improve in this PR, please let me know :wink:. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 00:42:06 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/proxmox-api-go#413
No description provided.