[PR #413] feat(config-qemu-memory-string): parse memory capacity both from string and integer. #451

New issue

Open

opened 2026-02-28 00:42:15 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:42:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/413
Author: @Andrew-Bezzubtsev
Created: 4/18/2025
Status: 🔄 Open

Base: master ← Head: feature/PROXMOX-8.4.1-memory-capacity

📝 Commits (1)

58f7740 feat(config-qemu-memory-string): parse memory capacity both from string and integer representations.

📊 Changes

2 files changed (+90 additions, -3 deletions)

View changed files

📝 proxmox/config_qemu_memory.go (+46 -3)
📝 proxmox/config_qemu_memory_test.go (+44 -0)

📄 Description

As for 8.4.1 (maybe earlier), GET /api2/json/nodes/{node}/qemu/{vmid}/config gives string value for "memory" field. This PR secures correct handling of both numeric and literal values.

For reference, see Proxmox VE API reference.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/413 **Author:** [@Andrew-Bezzubtsev](https://github.com/Andrew-Bezzubtsev) **Created:** 4/18/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `feature/PROXMOX-8.4.1-memory-capacity` --- ### 📝 Commits (1) - [`58f7740`](https://github.com/Telmate/proxmox-api-go/commit/58f774009cdbbf65733b0229e58a8c48f5b54af4) feat(config-qemu-memory-string): parse memory capacity both from string and integer representations. ### 📊 Changes **2 files changed** (+90 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config_qemu_memory.go` (+46 -3) 📝 `proxmox/config_qemu_memory_test.go` (+44 -0) </details> ### 📄 Description As for 8.4.1 (maybe earlier), `GET /api2/json/nodes/{node}/qemu/{vmid}/config` gives string value for `"memory"` field. This PR secures correct handling of both numeric and literal values. For reference, see [Proxmox VE API reference](https://pve.proxmox.com/pve-docs/api-viewer/#/nodes/{node}/qemu/{vmid}/config). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>