[PR #264] [MERGED] refactor: snapshot formatting #352

New issue

Closed

opened 2026-02-28 00:41:52 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/264
Author: @Tinyblargon
Created: 6/4/2023
Status: ✅ Merged
Merged: 6/7/2023
Merged by: @mleone87

Base: master ← Head: Refactor-Snapshot

📝 Commits (1)

73d2473 refactor: snapshot formatting

📊 Changes

3 files changed (+17 additions, -15 deletions)

View changed files

📝 cli/command/list/list-snapshots.go (+3 -3)
📝 proxmox/snapshot.go (+10 -8)
📝 proxmox/snapshot_test.go (+4 -4)

📄 Description

Introduced the private type rawSnapshots to make it easier for a user to figure out what to do with the output of ListSnapshots(). As before you needed to know that the output of the ListSnapshots() function was an intermediary step for FormatSnapshotsList() and FormatSnapshotsTree(). Due to this change the user would be able to figure it out with their IDE's auto-completion.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/264 **Author:** [@Tinyblargon](https://github.com/Tinyblargon) **Created:** 6/4/2023 **Status:** ✅ Merged **Merged:** 6/7/2023 **Merged by:** [@mleone87](https://github.com/mleone87) **Base:** `master` ← **Head:** `Refactor-Snapshot` --- ### 📝 Commits (1) - [`73d2473`](https://github.com/Telmate/proxmox-api-go/commit/73d24734757f9e20e9b757242f9c222fd17ff4a4) refactor: snapshot formatting ### 📊 Changes **3 files changed** (+17 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `cli/command/list/list-snapshots.go` (+3 -3) 📝 `proxmox/snapshot.go` (+10 -8) 📝 `proxmox/snapshot_test.go` (+4 -4) </details> ### 📄 Description Introduced the private type `rawSnapshots` to make it easier for a user to figure out what to do with the output of `ListSnapshots()`. As before you needed to know that the output of the `ListSnapshots()` function was an intermediary step for `FormatSnapshotsList()` and `FormatSnapshotsTree()`. Due to this change the user would be able to figure it out with their IDE's auto-completion. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>